Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate android_studio to null safety #79504

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Migrate android_studio to null safety #79504

merged 1 commit into from
Apr 2, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 1, 2021

  1. Migrate android_studio to null safety
  2. Move globals.android_studio from globals.dart to globals_null_migrated.dart.
  3. Remove extra AndroidStudio get androidStudio => context.get<AndroidStudio>() in android_studio.dart. In commands/config.dart (the only usage) prefer the globals.androidStudio instead.
  4. Add a test for AndroidStudio.latestValid() since I had to refactor it a bit to remove lastWhere since flutter_tool doesn't depend on collections and therefore can't use the suggested lastWhereOrNull replacement.

Part of #71511

@jmagman jmagman added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. a: null-safety Support for Dart's null safety feature labels Apr 1, 2021
@jmagman jmagman self-assigned this Apr 1, 2021
@google-cla google-cla bot added the cla: yes label Apr 1, 2021
jonahwilliams
jonahwilliams approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman
Copy link
Member Author

jmagman commented Apr 2, 2021

Google testing just mad it doesn't have g3fix for #79461.

@fluttergithubbot fluttergithubbot merged commit fb68d07 into flutter:master Apr 2, 2021
@jmagman jmagman deleted the null-as branch April 2, 2021 04:33
@jmagman jmagman mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
a: null-safety Support for Dart's null safety feature team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @fluttergithubbot @jonahwilliams