Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] use try to delete in web cache #82478

Merged
merged 1 commit into from
May 14, 2021
Merged

[flutter_tools] use try to delete in web cache #82478

merged 1 commit into from
May 14, 2021

Conversation

jonahwilliams
Copy link
Member

To handle the weird edge cases around directory deletion or other readonly system errors, use ErrorHandlingFileSystem.tryToDelete instead.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 13, 2021
@google-cla google-cla bot added the cla: yes label May 13, 2021
jmagman
jmagman approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit ed85dd4 into flutter:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @jmagman @fluttergithubbot