Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windowsIdentifier template parameter #82588

Merged
merged 1 commit into from
May 15, 2021
Merged

Add windowsIdentifier template parameter #82588

merged 1 commit into from
May 15, 2021

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented May 14, 2021 •
edited
Loading

Windows package identifiers are globally unique strings, typically a
GUID. These are required for templates that require a Windows package
name for publishing to the Microsoft Store as described in
https://docs.microsoft.com/en-us/windows/win32/appxpkg/appx-portal

Also adds tests for createAndroidIdentifier and createUTIIdentifier.

Fixes #82587

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 14, 2021
@google-cla google-cla bot added the cla: yes label May 14, 2021
clarkezone
clarkezone approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken
Add windowsIdentifier template parameter
42f9f76 
Windows package identifiers are globally unique strings, typically a
GUID. These are required for templates that require a Windows package
name as described in
https://docs.microsoft.com/en-us/windows/win32/appxpkg/appx-portal

Fixes flutter#82587
jonahwilliams
jonahwilliams approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding the tests!

christopherfujino
christopherfujino approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flutter flutter deleted a comment from flutter-dashboard bot May 15, 2021
@cbracken cbracken merged commit 90d978f into flutter:master May 15, 2021
@cbracken cbracken deleted the create-identifier branch May 15, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkezone clarkezone clarkezone approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Windows windowsIdentifer flutter create template parameter
4 participants
@cbracken @clarkezone @christopherfujino @jonahwilliams