Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter] use engine provided frame number #82934

Merged
merged 2 commits into from May 20, 2021
Merged

[flutter] use engine provided frame number #82934

merged 2 commits into from May 20, 2021

Conversation

jonahwilliams
Copy link
Member

#80735

Use the engine frame number for Flutter.frame events

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 19, 2021
@google-cla google-cla bot added the cla: yes label May 19, 2021
goderbauer
goderbauer approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jonahwilliams
Copy link
Member Author

This is failing g3 tests because it isn't using the right engine

@jonahwilliams jonahwilliams mentioned this pull request May 20, 2021
Merged
@fluttergithubbot fluttergithubbot merged commit 78a96b0 into flutter:master May 20, 2021
@jonahwilliams jonahwilliams deleted the use_frame_number branch May 20, 2021 20:52
@jonahwilliams jonahwilliams mentioned this pull request May 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonahwilliams @fluttergithubbot @goderbauer