Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go_router] Add ShellRoute #2453
[go_router] Add ShellRoute #2453
Changes from 93 commits
977f6bc
2db67e6
9ffd006
4da1fa0
100b33e
2387883
0f75672
4cdb183
a15b50b
93ca770
3ca5bf4
608f83b
dcab29d
469745a
f9f8c30
0436f1a
4bc4330
8eaf4e2
d92ce85
c794b87
cc27334
0028006
3a70fa5
183eb6a
3c9d725
340a6ca
d2fdeb9
c8deee5
c3c8f66
2c4585b
92ed4ae
41f5b06
780483a
f064d72
0819d4d
25e3236
de67875
bf1bad0
f82248f
44b8afd
02fe72e
631fd10
b4b4ac8
2d067d7
029ad91
d4bb46a
fb89778
61ebdb0
46609b0
2712c11
f38fa49
692bc46
c70f33c
e304529
55677e9
6248077
9378fd5
de8f97c
429d08b
a86b8fe
9be299a
813695b
8749762
85a1a6d
424afa4
cc28a23
f564e61
e7e795a
6c7867a
73f4747
d35a25b
0cf265a
1288344
50a31f0
3a9f206
bf54d73
e9ff347
c0794a4
c6bbccd
9d109db
886bee7
26e0515
27fb0f5
e3d31f8
146ede5
73899f2
97584c3
adc610d
c9f670b
9d92bbe
fb36859
70048b8
1e37f8f
a7426b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that folks will see this example and think you need to define a root navigator key to use
ShellRoute
. I wonder if we should have two separate shell route examples:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM - I'll break it out into two samples