-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gis_web] Improves renderButton API exports. #3432
Merged
auto-submit
merged 6 commits into
flutter:main
from
ditman:gis-web-fix-render-button-api
Mar 31, 2023
Merged
[gis_web] Improves renderButton API exports. #3432
auto-submit
merged 6 commits into
flutter:main
from
ditman:gis-web-fix-render-button-api
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
force-pushed
the
gis-web-fix-render-button-api
branch
from
March 9, 2023 23:42
dc9aac8
to
49af5dc
Compare
joshualitt
approved these changes
Mar 9, 2023
packages/google_identity_services_web/example/integration_test/src/dom.dart
Show resolved
Hide resolved
11 tasks
ditman
force-pushed
the
gis-web-fix-render-button-api
branch
from
March 16, 2023 03:20
0257a0d
to
2b68e4c
Compare
ditman
force-pushed
the
gis-web-fix-render-button-api
branch
from
March 16, 2023 04:10
2b68e4c
to
b54e5c1
Compare
ditman
changed the title
[gis_web] renderButton now accepts any js-interop target.
[gis_web] Improves renderButton API exports.
Mar 16, 2023
11 tasks
ditman
force-pushed
the
gis-web-fix-render-button-api
branch
from
March 17, 2023 21:48
90e132f
to
cbdf1ce
Compare
ditman
force-pushed
the
gis-web-fix-render-button-api
branch
from
March 28, 2023 23:09
cbdf1ce
to
d3c4924
Compare
stuartmorgan
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[gis_web] Improves renderButton API exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
renderButton
required exposingDomHtmlElement
from this library to the world. We don't want that, instead, the JS-Interop API should accept anything that is an HtmlElement (for now: Object).This PR also exposes the classes needed to configure the button that is rendered by the method.
Adds a small integration test to check that the behavior is valid.
(This PR removes the dependency on, and disallows the usage of the
jwt_decoder
package.)Pre-requirement for: flutter/flutter#121781
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.