Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gis_web] Improves renderButton API exports. #3432

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented Mar 9, 2023

The previous version of renderButton required exposing DomHtmlElement from this library to the world. We don't want that, instead, the JS-Interop API should accept anything that is an HtmlElement (for now: Object).

This PR also exposes the classes needed to configure the button that is rendered by the method.

Adds a small integration test to check that the behavior is valid.

(This PR removes the dependency on, and disallows the usage of the jwt_decoder package.)

Pre-requirement for: flutter/flutter#121781

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman force-pushed the gis-web-fix-render-button-api branch from 0257a0d to 2b68e4c Compare March 16, 2023 03:20
@ditman ditman force-pushed the gis-web-fix-render-button-api branch from 2b68e4c to b54e5c1 Compare March 16, 2023 04:10
@ditman ditman changed the title [gis_web] renderButton now accepts any js-interop target. [gis_web] Improves renderButton API exports. Mar 16, 2023
@ditman ditman force-pushed the gis-web-fix-render-button-api branch from 90e132f to cbdf1ce Compare March 17, 2023 21:48
@ditman ditman self-assigned this Mar 20, 2023
@ditman ditman force-pushed the gis-web-fix-render-button-api branch from cbdf1ce to d3c4924 Compare March 28, 2023 23:09
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@auto-submit auto-submit bot merged commit 7781aee into flutter:main Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
[gis_web] Improves renderButton API exports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants