Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_picker] fix typos in comments #3413

Merged
merged 2 commits into from
Mar 16, 2023
Merged

[image_picker] fix typos in comments #3413

merged 2 commits into from
Mar 16, 2023

Conversation

ElDavoo
Copy link
Contributor

@ElDavoo ElDavoo commented Mar 8, 2023

Removes two extraneous "fo".

This is just a simple typo fix , assuming I am correct that this is a typo.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

I ticked the relevant boxes

@ElDavoo ElDavoo requested a review from tarrinneal as a code owner March 8, 2023 11:40
@tarrinneal tarrinneal added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 8, 2023
tarrinneal
tarrinneal approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 8, 2023

auto label is removed for flutter/packages, pr: 3413, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 8, 2023

auto label is removed for flutter/packages, pr: 3413, due to Validations Fail.

@stuartmorgan stuartmorgan removed override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 9, 2023
stuartmorgan
stuartmorgan requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't version-exempt; these are documentation comments of public methods, and the most common way developers will see them is locally, in their IDE. That means that this needs to be published to be useful, so needs a version and changelog update.

@tarrinneal tarrinneal added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 16, 2023
stuartmorgan
stuartmorgan approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; per offline discussion we'll just skip the version bumps here.

@tarrinneal
Copy link
Contributor

tarrinneal commented Mar 16, 2023 •
edited
Loading

Adding version exemption since this change is fine to get published when another pr pulls it in.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 16, 2023

auto label is removed for flutter/packages, pr: 3413, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit bot merged commit f5687b2 into flutter:main Mar 16, 2023
@ElDavoo
Copy link
Contributor Author

ElDavoo commented Mar 16, 2023

Ok, i was going to rebase it but then forgot, thank you for merging!

@ElDavoo ElDavoo deleted the fix-image-picker-comments branch March 16, 2023 17:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
f5687b2 [image_picker] fix typos in comments (flutter/packages#3413)
fea1824
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
f5687b2 [image_picker] fix typos in comments (flutter/packages#3413)
b4fd903
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2023
@engine-flutter-autoroll
f5687b2 [image_picker] fix typos in comments (flutter/packages#3413)
d09ce57
tarrinneal pushed a commit to flutter/flutter that referenced this pull request Mar 20, 2023
@engine-flutter-autoroll
Roll Packages from 44ddf2c to bbf86a7 (19 revisions) (#123015)
95256c0 
* 7636eb7 [go_router_builder] Support default value for `Set`, `List` and `Iterable` route parameters (flutter/packages#3391)

* 26c95da [image_picker] Move HashSet construction within if-statement (flutter/packages#3448)

* f5687b2 [image_picker] fix typos in comments (flutter/packages#3413)

* 84afba7 [image_picker] Migrate Android to Pigeon (flutter/packages#3476)

* 42927fc [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.3 to 1.3.6 in /packages/image_picker/image_picker_android/android (flutter/packages#3238)

* 9a44bdf Require Dart SDK 2.14, because of using APIs. (flutter/packages#3468)

* 12609a2 [ci] Clean up iOS simulators (flutter/packages#3458)

* 9b136a9 [ci/tool] Add external dependency validation (flutter/packages#3466)

* 11aab47 Manual roll Flutter from fb7e828 to 67e5f66 (8 revisions) (flutter/packages#3482)

* 784291b Update goldens (flutter/packages#3442)

* 43a42d1 [webview_flutter_android] Updates Dart and Java InstanceManagers (flutter/packages#3282)

* d0de136 [camera] Reland android flip/change camera while recording (flutter/packages#3460)

* 74fd094 [image_picker_android] Adjust file extension in FileUtils when it does not match its mime type (flutter/packages#3409)

* d2f1d2d [flutter_adaptive_scaffold] : 🐛 [FIX] : Issue: 121135. (flutter/packages#3253)

* 3d078b5 Roll Flutter from 67e5f66 to 53dfd23 (39 revisions) (flutter/packages#3484)

* 3b3a09d [url_launcher] Convert iOS to Pigeon (flutter/packages#3481)

* 80cd50a Roll Flutter from 53dfd23 to 6bd2b3c (17 revisions) (flutter/packages#3486)

* 998bb29 [webview_flutter] Updates the README with the migration of `WebView.initialCookies` and Hybrid Composition on (flutter/packages#3470)

* bbf86a7 Roll Flutter from 6bd2b3c to 3e4e092 (7 revisions) (flutter/packages#3490)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@ElDavoo @nploi
[image_picker] fix typos in comments (flutter#3413)
7dab441 
[image_picker] fix typos in comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: image_picker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElDavoo @tarrinneal @stuartmorgan