Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Adds popUntil to GoRouter and its extension #4557

Closed
wants to merge 1 commit into from

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jul 24, 2023

fixes flutter/flutter#131625

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ValentinVignal
Copy link
Contributor

@chunhtai I sent you a message on Discord to suggest another signature for popUntil because I'm trying to make the RouteMatchList a tree. Maybe it would be nice to talk about it?

@chunhtai
Copy link
Contributor Author

@chunhtai I sent you a message on Discord to suggest another signature for popUntil because I'm trying to make the RouteMatchList a tree. Maybe it would be nice to talk about it?

Which channel did you send the message? I didn't see any notification. Can you ping me on the hackers-routing- channel?

Yes, we should definitely talk about it if this doesn't work well with the new RouteMatchList.

@chunhtai chunhtai changed the title [go_router] Adds popUntil to GoRouter and its extension [Draft] Adds popUntil to GoRouter and its extension Jul 31, 2023
@chunhtai chunhtai marked this pull request as draft July 31, 2023 20:13
@flodaniel
Copy link

@chunhtai is there a result to the discussion around this and relation to a new RouteMatchList? I was just looking for this feature.

@chunhtai
Copy link
Contributor Author

chunhtai commented Nov 2, 2023

Close for now until i have time to come back to this pr

@chunhtai chunhtai closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go_router] support popUntil
3 participants