Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[various] Update invalid NSURL tests #4959

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[various] Update invalid NSURL tests #4959

merged 1 commit into from
Sep 20, 2023

Conversation

stuartmorgan
Copy link
Contributor

For applications linked against iOS 17 or later, NSURL no longer returns nil for invalid URLs, so tests that were specific to that behavior have to be adjusted to allow for another outcome.

Fixes flutter/flutter#134972
Part of flutter/flutter#134971

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
[various] Update invalid NSURL tests
1676f90 
For applications linked against iOS 17 or later, NSURL no longer returns
`nil` for invalid URLs, so tests that were specific to that behavior
have to be adjusted to allow for another outcome.

Fixes flutter/flutter#134972
Part of flutter/flutter#134971
cyanglaz
cyanglaz approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2023
@auto-submit auto-submit bot merged commit d0411e4 into flutter:main Sep 20, 2023
70 checks passed
@stuartmorgan stuartmorgan deleted the nsurl-changes-test-updates branch September 21, 2023 13:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
d0411e4 [various] Update invalid NSURL tests (flutter/packages#4959)
100270a
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
Roll Packages from 51e74b9 to d0411e4 (1 revision) (#135224)
8f04f0c 
flutter/packages@51e74b9...d0411e4

2023-09-20 stuartmorgan@google.com [various] Update invalid NSURL tests (flutter/packages#4959)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
pro100andrey added a commit to pro100andrey/packages that referenced this pull request Sep 25, 2023
@pro100andrey
Merge branch 'main' into feature/fix
6787627 
* main: (590 commits)
  Bump github/codeql-action from 2.21.7 to 2.21.8 (flutter#4952)
  Manual roll Flutter from 8936504 to f92884c (48 revisions) (flutter#4985)
  [image_picker_android] check if data from result is empty when picking a single img or video (flutter#4836)
  [camera_android] Removes usage of `_ambiguate` method in tests (flutter#4948)
  [sign_in]: Bump com.google.android.gms:play-services-auth from 20.6.0 to 20.7.0 in /packages/google_sign_in/google_sign_in_android/android (flutter#4841)
  Manual roll Flutter (stable) from 367f9ea16bfa to 12fccda59847 (2 revisions) (flutter#4976)
  [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr… (flutter#4723)
  [webview_flutter_wkwebview] Adds WKWebView implementation to override console log (flutter#4703)
  [various] Update invalid NSURL tests (flutter#4959)
  [ios_platform_images] Convert to Pigeon (flutter#4945)
  [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter#4880)
  Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter#4947)
  [go_router] Adds on exit (flutter#4699)
  [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter#4713)
  [file_selector] Fix unknown extensions on macOS (flutter#4946)
  [camera_avfoundation] ignore audio samples until first video sample (flutter#4587)
  Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter#4944)
  [video_player] isCompleted event. (flutter#4923)
  [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter#4881)
  [google_sign_in] Convert iOS to Pigeon (flutter#4941)
  ...

# Conflicts:
#	packages/camera/camera/pubspec.yaml
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from 51e74b9 to d0411e4 (1 revision) (flutter#135224)
bdd3488 
flutter/packages@51e74b9...d0411e4

2023-09-20 stuartmorgan@google.com [various] Update invalid NSURL tests (flutter/packages#4959)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@stuartmorgan @HugoOlthof
[various] Update invalid NSURL tests (flutter#4959)
f609bd2 
For applications linked against iOS 17 or later, NSURL no longer returns `nil` for invalid URLs, so tests that were specific to that behavior have to be adjusted to allow for another outcome.

Fixes flutter/flutter#134972
Part of flutter/flutter#134971
@stuartmorgan stuartmorgan mentioned this pull request May 6, 2024
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request May 10, 2024
@stuartmorgan
[url_launcher] Add Swift Package Manager support (#6677)
75930f8 
Adds SPM support for both iOS and macOS.

Also opportunistically updates the unit tests for macOS to match the changes made in #4959 since I noticed that they were failing when running locally. This will prevent issues when we update CI in the future.

Fixes flutter/flutter#146916
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@stuartmorgan @TecHaxter
[url_launcher] Add Swift Package Manager support (flutter#6677)
fca79e8 
Adds SPM support for both iOS and macOS.

Also opportunistically updates the unit tests for macOS to match the changes made in flutter#4959 since I noticed that they were failing when running locally. This will prevent issues when we update CI in the future.

Fixes flutter/flutter#146916
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@stuartmorgan @arc-yong
[url_launcher] Add Swift Package Manager support (flutter#6677)
b7970db 
Adds SPM support for both iOS and macOS.

Also opportunistically updates the unit tests for macOS to match the changes made in flutter#4959 since I noticed that they were failing when running locally. This will prevent issues when we update CI in the future.

Fixes flutter/flutter#146916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: url_launcher p: webview_flutter platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCTests and XCUITests failing on webview_flutter_wkwebview package iOS 17 XCode RC1
2 participants
@stuartmorgan @cyanglaz