[rfw] Enable subscribing to the root of a DynamicContent #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnmccutchan is this something you still need, or did you find another solution? |
|
This is no longer needed by my tool but it does seem like something that should be supported for consistency reasons. |
|
Would you like to be the reviewer, since you have context? :-) |
johnmccutchan
approved these changes
Jan 26, 2024
| @@ -12,6 +12,9 @@ import 'package:flutter/foundation.dart' show objectRuntimeType; | |||
| import '../dart/model.dart'; | |||
|
|
|||
| /// Signature for the callback passed to [DynamicContent.subscribe]. | |||
| /// | |||
| /// Do not modify the provided value (e.g. if it is a map or list). Doing so | |||
There was a problem hiding this comment.
Should you pass the map/list wrapped in an UnmodifiableFoo wrapper so that the user can't manipulate it?
There was a problem hiding this comment.
I would if it was a free abstraction, but given that it's standard practice in Flutter to pass around lists and maps that aren't supposed to be modified, I don't see much point.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2024
flutter/packages@25abb5d...5b48c44 2024-01-30 ian@hixie.ch [rfw] Enable subscribing to the root of a DynamicContent (flutter/packages#5848) 2024-01-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds ProxyApi to AST generation (flutter/packages#5861) 2024-01-30 stuartmorgan@google.com [tool] Exempt federated impl examples from CHANGELOG (flutter/packages#6018) 2024-01-30 engine-flutter-autoroll@skia.org Manual roll Flutter from 2f6fdf2 to ace9181 (57 revisions) (flutter/packages#6013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#141069
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).