Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each #6109

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Feb 12, 2024

Modifies CameraInitializedEvent to

  1. Set the initial exposure and focus modes to auto, since CameraX defaults to auto exposure mode and only supports auto focus mode without Camera2 interop
  2. Sets the ability to set focus and exposure points to be true, since CameraX supports these by default

Should land after #6059 so that these values reflect what is actually implemented on our end Done :)

Pre-launch Checklist

@camsim99 camsim99 requested a review from a team February 21, 2024 17:51
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2024
@auto-submit auto-submit bot merged commit 784190c into flutter:main Feb 21, 2024
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
… AF/AE modes and the ability to set focus points for each (flutter/packages#6109)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 22, 2024
flutter/packages@48048f6...078c2a3

2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter from 5129806 to efee280 (47 revisions) (flutter/packages#6180)
2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from bae5e49 to abb292a (1 revision) (flutter/packages#6179)
2024-02-21 louisehsu@google.com [in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165)
2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each (flutter/packages#6109)
2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` (flutter/packages#6059)
2024-02-21 stuartmorgan@google.com [various] Commit Windows build migrations (flutter/packages#6175)
2024-02-21 kevmoo@users.noreply.github.com [flutter_markdown] Support wasm (flutter/packages#6168)
2024-02-21 737941+loic-sharma@users.noreply.github.com [ci] Run Windows Arm64 build tests post-submit (flutter/packages#6166)
2024-02-21 stuartmorgan@google.com [url_launcher] Remove `renderView` usage (flutter/packages#6137)
2024-02-21 b@sdevaan.nl [camera_android_camerax] Fix typo in readme (flutter/packages#6143)
2024-02-21 stuartmorgan@google.com [local_auth] Switch iOS endorsement to `local_auth_darwin` (flutter/packages#6107)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Feb 27, 2024
Implements `setExposureMode`.

Fixes flutter/flutter#120468.

~To be landed after (1) #6059 then (2) #6109 Done :)
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
Implements `setExposureMode`.

Fixes flutter/flutter#120468.

~To be landed after (1) flutter#6059 then (2) flutter#6109 Done :)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…odes and the ability to set focus points for each (flutter#6109)

Modifies `CameraInitializedEvent` to
1. Set the initial exposure and focus modes to auto, since CameraX defaults to auto exposure mode and only supports auto focus mode without Camera2 interop
2. Sets the ability to set focus and exposure points to be true, since CameraX supports these by default

~Should land after flutter#6059 so that these values reflect what is actually implemented on our end~ Done :)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Implements `setExposureMode`.

Fixes flutter/flutter#120468.

~To be landed after (1) flutter#6059 then (2) flutter#6109 Done :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants