Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip podspec Swift Search Path validation if only swift file is Package.swift for darwin plugins #6635

Merged

Conversation

vashworth
Copy link
Contributor

Fix for iOS was added in #6627, but neglected to handle when plugin uses darwin directory.

Supplemental fix for flutter/flutter#147548.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024
@auto-submit auto-submit bot merged commit 62c08f4 into flutter:main May 2, 2024
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 3, 2024
flutter/packages@aea93d2...f4719ca

2024-05-02 reidbaker@google.com [in_app_purchase] implement countryCode correctly (flutter/packages#6636)
2024-05-02 15619084+vashworth@users.noreply.github.com Skip podspec Swift Search Path validation if only swift file is Package.swift for darwin plugins (flutter/packages#6635)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter from d33bb8f to bf7191f (34 revisions) (flutter/packages#6637)
2024-05-01 petermnt@users.noreply.github.com [webview_flutter_android] Fixes iframe navigation with `onNavigationRequest` (flutter/packages#6335)
2024-05-01 engine-flutter-autoroll@skia.org Roll Flutter from b597dd2 to d33bb8f (7 revisions) (flutter/packages#6633)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…ge.swift for darwin plugins (flutter#6635)

Fix for iOS was added in flutter#6627, but neglected to handle when plugin uses darwin directory.

Supplemental fix for flutter/flutter#147548.
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…ge.swift for darwin plugins (flutter#6635)

Fix for iOS was added in flutter#6627, but neglected to handle when plugin uses darwin directory.

Supplemental fix for flutter/flutter#147548.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants