This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
build macos --config-only
option. (#118649)
Co-authored-by: a-wallen <stephenwallen@google.com>
- Loading branch information
Showing
3 changed files
with
96 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
packages/flutter_tools/test/integration.shard/build_macos_config_only_test.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
// Copyright 2014 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'package:file_testing/file_testing.dart'; | ||
import 'package:flutter_tools/src/base/file_system.dart'; | ||
import 'package:flutter_tools/src/base/io.dart'; | ||
|
||
import '../src/common.dart'; | ||
import 'test_utils.dart'; | ||
|
||
void main() { | ||
test('flutter build macOS --config only updates generated xcconfig file without performing build', () async { | ||
final String workingDirectory = fileSystem.path.join( | ||
getFlutterRoot(), | ||
'dev', | ||
'integration_tests', | ||
'flutter_gallery', | ||
); | ||
final String flutterBin = fileSystem.path.join(getFlutterRoot(), 'bin', 'flutter'); | ||
|
||
await processManager.run(<String>[ | ||
flutterBin, | ||
...getLocalEngineArguments(), | ||
'clean', | ||
], workingDirectory: workingDirectory); | ||
final List<String> buildCommand = <String>[ | ||
flutterBin, | ||
...getLocalEngineArguments(), | ||
'build', | ||
'macos', | ||
'--config-only', | ||
'--release', | ||
'--obfuscate', | ||
'--split-debug-info=info', | ||
]; | ||
final ProcessResult firstRunResult = await processManager.run(buildCommand, workingDirectory: workingDirectory); | ||
|
||
printOnFailure('Output of flutter build macOS:'); | ||
final String firstRunStdout = firstRunResult.stdout.toString(); | ||
printOnFailure('First run stdout: $firstRunStdout'); | ||
printOnFailure('First run stderr: ${firstRunResult.stderr}'); | ||
|
||
expect(firstRunResult.exitCode, 0); | ||
expect(firstRunStdout, contains('Running pod install')); | ||
|
||
final File generatedConfig = fileSystem.file(fileSystem.path.join( | ||
workingDirectory, | ||
'macos', | ||
'Flutter', | ||
'ephemeral', | ||
'Flutter-Generated.xcconfig', | ||
)); | ||
|
||
// Config is updated if command succeeded. | ||
expect(generatedConfig, exists); | ||
expect(generatedConfig.readAsStringSync(), contains('DART_OBFUSCATION=true')); | ||
|
||
// file that only exists if app was fully built. | ||
final File frameworkPlist = fileSystem.file(fileSystem.path.join( | ||
workingDirectory, | ||
'build', | ||
'macos', | ||
'Build', | ||
'Products', | ||
'Release', | ||
'App.framework', | ||
'Resources', | ||
'Info.plist' | ||
)); | ||
|
||
expect(frameworkPlist, isNot(exists)); | ||
|
||
// Run again with no changes. | ||
final ProcessResult secondRunResult = await processManager.run(buildCommand, workingDirectory: workingDirectory); | ||
final String secondRunStdout = secondRunResult.stdout.toString(); | ||
printOnFailure('Second run stdout: $secondRunStdout'); | ||
printOnFailure('Second run stderr: ${secondRunResult.stderr}'); | ||
|
||
expect(secondRunResult.exitCode, 0); | ||
}, skip: !platform.isMacOS); // [intended] macOS builds only work on macos. | ||
} |