-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] Adds support for polygon overlays to the Google Maps plugin #1551
Conversation
This is relatively trivial, requiring only some additional logic to disambiguate click events between the various possible overlays. Also adds a page to the example app demonstrating polygons, which I tested on iOS and Android.
@matthewlloyd , I will have time to look at this only next week. We have Google I/O coming up. Sorry for the delay on this. |
No rush, enjoy Google I/O! I'll be watching some of the live streams. |
Any update on this? |
Still waiting for review. If you want to use it sooner, you can always fork my repo from https://github.com/matthewlloyd/plugins and switch to the
Of course if you do this and build code on my version of the plugin, there's no guarantee the API won't change during the review before it gets merged, but I think that is unlikely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@matthewlloyd , I finally got a chance to take a look at this. Please fix the changelog and pubspec. Let's merge it :-) |
Great! I'm AFK currently but will get it updated before tomorrow morning. |
Hello. Why didn't you add support for holes in the polygons? It's just one more field (list of LatLng) in polygon model. |
No technical reason not to do so, just a lack of time and not something I needed. I'm sure the Google team would be happy to review the addition if you submit a PR. |
Okay, I'll try to do it. |
Description
Adds support for polygon overlays to the Google Maps plugin
This is relatively trivial, requiring only some additional logic
to disambiguate click events between the various possible overlays.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?