Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Adds support for polygon overlays to the Google Maps plugin #1551

Merged
merged 3 commits into from
May 30, 2019
Merged

Conversation

matthewlloyd
Copy link
Contributor

Description

Adds support for polygon overlays to the Google Maps plugin

This is relatively trivial, requiring only some additional logic
to disambiguate click events between the various possible overlays.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This is relatively trivial, requiring only some additional logic
to disambiguate click events between the various possible overlays.

Also adds a page to the example app demonstrating polygons,
which I tested on iOS and Android.
@iskakaushik
Copy link
Contributor

@matthewlloyd , I will have time to look at this only next week. We have Google I/O coming up. Sorry for the delay on this.

@matthewlloyd
Copy link
Contributor Author

No rush, enjoy Google I/O! I'll be watching some of the live streams.

@andreyeurope
Copy link

Any update on this?

@matthewlloyd
Copy link
Contributor Author

Still waiting for review. If you want to use it sooner, you can always fork my repo from https://github.com/matthewlloyd/plugins and switch to the polygon branch, then reference the fork in your pubspec.yaml like this:

  google_maps_flutter:
    path: plugins/packages/google_maps_flutter

Of course if you do this and build code on my version of the plugin, there's no guarantee the API won't change during the review before it gets merged, but I think that is unlikely.

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik
Copy link
Contributor

@matthewlloyd , I finally got a chance to take a look at this. Please fix the changelog and pubspec. Let's merge it :-)

@matthewlloyd
Copy link
Contributor Author

Great! I'm AFK currently but will get it updated before tomorrow morning.

@iskakaushik iskakaushik merged commit 4900e75 into flutter:master May 30, 2019
@sanekyy
Copy link
Contributor

sanekyy commented Jun 6, 2019

Hello. Why didn't you add support for holes in the polygons? It's just one more field (list of LatLng) in polygon model.

@matthewlloyd
Copy link
Contributor Author

matthewlloyd commented Jun 6, 2019

No technical reason not to do so, just a lack of time and not something I needed. I'm sure the Google team would be happy to review the addition if you submit a PR.

@sanekyy
Copy link
Contributor

sanekyy commented Jun 6, 2019

Okay, I'll try to do it.

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
)

* Updated the documentation language.

The english was a bit confusing.

* Update packages/firebase_crashlytics/CHANGELOG.md

Co-Authored-By: Collin Jackson <jackson@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants