Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

add a dynamic get method to shared_preferences #375

Merged
merged 5 commits into from
Feb 5, 2018
Merged

add a dynamic get method to shared_preferences #375

merged 5 commits into from
Feb 5, 2018

Conversation

long1eu
Copy link
Contributor

@long1eu long1eu commented Jan 28, 2018

No description provided.

@long1eu long1eu changed the title add a dynamic get method add a dynamic get method to shared_preferences Jan 28, 2018
@Hixie
Copy link
Contributor

Hixie commented Jan 30, 2018

cc @collinjackson

mravn-google
mravn-google approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@mravn-google mravn-google left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.
We need a change log entry and a version bump to go with this change.

@collinjackson collinjackson self-assigned this Feb 5, 2018
@long1eu
Copy link
Contributor Author

long1eu commented Feb 5, 2018

Thanks!

@collinjackson collinjackson merged commit c4cc677 into flutter:master Feb 5, 2018
@collinjackson
Copy link
Contributor

Merged and published

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mravn-google mravn-google mravn-google approved these changes

Assignees

@collinjackson collinjackson

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@long1eu @Hixie @collinjackson @mravn-google @googlebot