This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[tool] add an skip-confirmation flag to publish-package for running the command on ci
#3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
suggested changes
May 4, 2021
| @@ -84,6 +84,14 @@ class PublishPluginCommand extends PluginCommand { | |||
| defaultsTo: false, | |||
| negatable: true, | |||
| ); | |||
| argParser.addFlag(_yesOption, | |||
| help: 'Running the command without asking for Y/N inputs.\n' | |||
| help: 'Running the command without asking for Y/N inputs.\n' | ||
| 'This command will add a `--force` flag to the `pub publish` command if it is not added with $_pubFlagsOption\n' | ||
| 'It also skips the y/n inputs when pushing tags to remote.\n' | ||
| 'If running this on CI, an environment variable named $_pubCredentialName must be set to a String that represents the pub credential JSON.\n' |
There was a problem hiding this comment.
This (and the next line) isn't really about this flag in particular, is it?
| @@ -93,6 +101,9 @@ class PublishPluginCommand extends PluginCommand { | |||
| static const String _remoteOption = 'remote'; | |||
| static const String _allChangedFlag = 'all-changed'; | |||
| static const String _dryRunFlag = 'dry-run'; | |||
| static const String _yesOption = 'yes'; | |||
There was a problem hiding this comment.
How about --skip-confirmation since that makes it self-documenting where it's used?
(Also because no-skip-confirmation makes a lot more sense for the negated version than no-yes.)
cyanglaz
commented
May 4, 2021
cyanglaz
changed the title
yes flag to publish-package for running the command on ciskip-confirmation flag to publish-package for running the command on ci
stuartmorgan
approved these changes
May 5, 2021
| fileSystem.file(credentialPath) | ||
| ..createSync(recursive: true) | ||
| ..writeAsStringSync('some credential'); | ||
| } | ||
|
|
||
| setUp(() async { | ||
| // This test uses a local file system instead of an in memory one throughout | ||
| // so that git actually works. In setup we initialize a mono repo of plugins | ||
| // with one package and commit everything to Git. |
There was a problem hiding this comment.
Please move the local filesystem part of this comment up to line 32.
| @@ -49,8 +56,7 @@ void main() { | |||
| processRunner = TestProcessRunner(); | |||
| mockStdin = MockStdin(); | |||
| commandRunner = CommandRunner<void>('tester', '') | |||
| ..addCommand(PublishPluginCommand( | |||
| mockPackagesDir, mockPackagesDir.fileSystem, | |||
| ..addCommand(PublishPluginCommand(mockPackagesDir, fileSystem, | |||
There was a problem hiding this comment.
I'd like to move away from mockPackagesDir, since it's weirdly indirect. parentDir is the same directory, but much more clear based on local context.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2021
… running the command on ci (flutter/plugins#3842)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2021
… running the command on ci (flutter/plugins#3842)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
… running the command on ci (flutter/plugins#3842)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
… running the command on ci (flutter/plugins#3842)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2021
… running the command on ci (flutter/plugins#3842)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
… running the command on ci (flutter/plugins#3842)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
… running the command on ci (flutter/plugins#3842)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
… running the command on ci (flutter/plugins#3842)
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
… the command on ci (flutter#3842) the skip-confirmation flag will add a --force flag to pub publish, it will also let users to skip the y/n question when pushing tags to remote. Fixes flutter/flutter#79830
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
skip-confirmationflag will add a--forceflag topub publish, it will also let users to skip the y/n question when pushing tags to remote.Fixes flutter/flutter#79830
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.