[video player]: update the url in the readme example

[maheshj01]

This pull request updates the URL in the video_player sample code in the Readme.

Related issues:

• This PR resolves the issue #84982

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[stuartmorgan]

Thanks for the submission!

In the future, please don't remove the checklist from the template; it's there for a reason. This change needs to update the version so that it can be published, which was explained in that checklist.

(I think the better solution here would actually be to remove this section entirely, since pub.dev shows the example app's main file anyway, but this is fine as an incremental change.)

[maheshj01]

Thanks for the submission!

In the future, please don't remove the checklist from the template; it's there for a reason. This change needs to update the version so that it can be published, which was explained in that checklist.

(I think the better solution here would actually be to remove this section entirely, since pub.dev shows the example app's main file anyway, but this is fine as an incremental change.)

I am sorry I couldn't understand which checklist you are referring to could you please explain?

[stuartmorgan]

When you created the PR, there was a template in the PR description section that should have been filled in; see almost any other PR in the repository for an example. You deleted all of that text rather than filling in the template and following the checklist that was part of it.

[maheshj01]

When you created the PR, there was a template in the PR description section that should have been filled in; see almost any other PR in the repository for an example. You deleted all of that text rather than filling in the template and following the checklist that was part of it.

Ohh got it, Sorry about that let me correct it,
I will make sure this doesn't happen on my future PRs :)
Let me know if there is anything else I need to fix.
Thanks

[stuartmorgan]

Let me know if there is anything else I need to fix.

As I said above:

This change needs to update the version so that it can be published, which was explained in that checklist.

which is why I brought up the checklist in the first place.

[maheshj01]

Sorry about that again, so If I understand correctly these checks auto-publish the plugin to pub.dev which is why they are necessary.

[stuartmorgan]

these checks

I'm not sure what "these checks" refers to.

which is why they are necessary.

Changing the version is necessary because we cannot publish updates to a package without giving the package a new version. Whether the publishing is automatic or manual isn't relevant here.

[maheshj01]

@stuartmorgan, Please let me know if there is anything I need to do from my side to get this merged.

Thank you for the review.

[stuartmorgan]

@stuartmorgan, Please let me know if there is anything I need to do from my side to get this merged.

I've told you in every single comment above that you need to update the version; I'm not sure how I can be more clear about this.

[stuartmorgan]

(Updating review state per comment above)

[stuartmorgan]

Why did you rewrite the entire changelog?

[maheshj01]

I am really sorry about that actually its my IDE, when I saved the file, it auto-formatted the file. I have reverted the changes and pushed the updated changelog.
I have turned off the formatting now it won't happen in the future.

[stuartmorgan]

LGTM