This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add map camera control API #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mravn-google
commented
Apr 4, 2018
•
mravn-google
commented
- Add Dart API to move and animate map camera.
- Add Android implementation.
- Restructure plugin to use Dart library and parts.
sigurdm
approved these changes
Apr 5, 2018
| googleMap.animateCamera(cameraUpdate); | ||
| void moveCamera(final CameraUpdate cameraUpdate) { | ||
| if (googleMap == null) { | ||
| pendingOperations.add( |
There was a problem hiding this comment.
We might want to save the pre-initialized operations on the dart side to avoid duplicating this logic for ios.
| ) | ||
| ], | ||
| body: new NotificationListener<ScrollNotification>( | ||
| onNotification: (ScrollNotification sn) { |
There was a problem hiding this comment.
Nit:
Don't abbreviate. sn => scrollNotification
| ); | ||
| } | ||
|
|
||
| static CameraUpdate newLatLong(LatLng latLng) { |
| /// | ||
| /// Used for programmatically controlling a platform-specific | ||
| /// GoogleMaps view, once it has been created and integrated | ||
| /// into the Flutter application. |
There was a problem hiding this comment.
"once it has been created and integrated into the Flutter application." => "once it has been initialized."?
|
|
||
| part of google_mobile_maps; | ||
|
|
||
| class Marker {} |
mravn-google
commented
Apr 5, 2018
| googleMap.animateCamera(cameraUpdate); | ||
| void moveCamera(final CameraUpdate cameraUpdate) { | ||
| if (googleMap == null) { | ||
| pendingOperations.add( |
| ); | ||
| } | ||
|
|
||
| static CameraUpdate newLatLong(LatLng latLng) { |
| ) | ||
| ], | ||
| body: new NotificationListener<ScrollNotification>( | ||
| onNotification: (ScrollNotification sn) { |
|
|
||
| part of google_mobile_maps; | ||
|
|
||
| class Marker {} |
| /// | ||
| /// Used for programmatically controlling a platform-specific | ||
| /// GoogleMaps view, once it has been created and integrated | ||
| /// into the Flutter application. |
slightfoot
pushed a commit
to slightfoot/plugins
that referenced
this pull request
Jun 5, 2018
amirh
pushed a commit
to amirh/plugins
that referenced
this pull request
Nov 28, 2018
This was done in flutter#463, not sure why, but I don't think we should export it (and it makes Dartdoc complain).
amirh
added a commit
that referenced
this pull request
Nov 28, 2018
This was done in #463, not sure why, but I don't think we should export it (and it makes Dartdoc complain).
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This was done in flutter#463, not sure why, but I don't think we should export it (and it makes Dartdoc complain).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.