This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Refactored tests to expose private interface in separate test header. #4722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
force-pushed
the
image_picker_test_header
branch
5 times, most recently
from
12a3e7c
to
bd955e9
Compare
stuartmorgan
suggested changes
Feb 2, 2022
packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin_Test.h
Show resolved
Hide resolved
packages/image_picker/image_picker/ios/Classes/image_picker-umbrella.h
Outdated
Show resolved
Hide resolved
jmagman
reviewed
Feb 2, 2022
packages/image_picker/image_picker/ios/Classes/image_picker-umbrella.h
Outdated
Show resolved
Hide resolved
11 tasks
Refactored the existing unit tests to expose private interfaces in a separate test header instead of an inline interface. This was first introduced in the google_sign_in plugin (flutter#4157) and after that also applied in the camera plugin (flutter#4426) and the webview_flutter plugin (flutter#4480).
mvanbeusekom
force-pushed
the
image_picker_test_header
branch
from
3921f8d
to
ce306e7
Compare
stuartmorgan
reviewed
Feb 7, 2022
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| @import image_picker; | |||
| @import XCTest; | |||
| #import <image_picker/FLTImagePickerImageUtil.h> | |||
There was a problem hiding this comment.
Isn't this still relying on the bug in the framework (that it includes this header in the packaged framework at all)?
Pre module-map I would expect this to just be #import "FLTImagePickerImageUtil.h" with appropriate include paths for the target. I expect there's probably a cleaner way using the Test module though?
There was a problem hiding this comment.
@mvanbeusekom i think you can put this header under the submodule Test that you've created, and just do @import image_picker.Test; here.
There was a problem hiding this comment.
The solution proposed by @hellohuanlin worked like a charm. Thanks
mvanbeusekom
force-pushed
the
image_picker_test_header
branch
from
ce306e7
to
31442f3
Compare
jmagman
approved these changes
Feb 7, 2022
|
@stuartmorgan this needs another review since you requested changes. |
stuartmorgan
approved these changes
Feb 8, 2022
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 8, 2022
… in separate test header. (flutter/plugins#4722)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the existing unit tests to expose private interfaces in a separate test header instead of an inline interface. This was first introduced in the google_sign_in plugin (#4157) and after that also applied in the camera plugin (#4426) and the webview_flutter plugin (#4480).
I have moved this refactoring out of the changes I am working on for issue flutter/flutter#96903 and PR #4718.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).