[webview_flutter] Add file upload on Android #5172

dupuchba · 2022-04-05T13:57:12Z

Currently on Android nothing happens for <input type="file">
This PR solves that by registering the callback onShowFileChooser on the WebView that must returns a Future<List<String>> (list of file path).
It lets you use which-ever file-provider plugin you want to use as recommended by @stuartmorgan here.

Status:

Tried it with [image_provider] and it's working
Before diving into tests, I hope to have feedbacks on the implementation.
Need to read all Contributor guides

Thanks all

Related issues

#3225
flutter/flutter#27924

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…droidWebView

flutter-dashboard · 2022-04-05T13:57:16Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

google-cla · 2022-04-05T13:57:19Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

Line was not supposed to be committed

…ch/flutter-plugins into android-on-show-file-chooser

stuartmorgan

Thanks for the submission! At a high level this looks like what was discussed in the previous PR. @bparrishMines should take a high-level look as well.

There is an issue currently blocking moving forward with this though, as noted below (unless we added a different, separate handler object, but that would be ugly).

stuartmorgan · 2022-04-05T15:58:20Z

...lutter_platform_interface/lib/src/platform_interface/webview_platform_callbacks_handler.dart

@@ -27,6 +27,8 @@ abstract class WebViewPlatformCallbacksHandler {
  /// /// Only works when [WebSettings.hasProgressTracking] is set to `true`.
  void onProgress(int progress);

+  Future<List<String>> onShowFileChooser();


This is a breaking change as things are currently structured, so adding this will need to wait for the platform interface API update.

@mvanbeusekom @bparrishMines Can we verify that this kind of change will indeed by safe in the updated version?

Yes, I don't see any reason this won't be possible with the new interface. The only difference is that we may make this unique to AndroidWebViewControllerDelegate. Which would only slightly change how it is used in this PR.

@bparrishMines what's the branch of the "new interface" ?
I understand that you are refactoring webview_flutter and you want to be sure that this PR will fit the new design.

The work on the new interface can be tracked at: flutter/flutter#94051.

Ok, in the meantime, this PR is stale right ?

Not all of it. The part that adds it to the native api WebChromeClient wrapper should remain valid. Reducing the PR to this will make it easier to add it to the new interface at a later point.

Hixie · 2022-06-07T23:19:20Z

@dupuchba Are you interested in following-up with the narrower scope @bparrishMines suggested above?

dupuchba · 2022-06-08T12:58:45Z

@dupuchba Are you interested in following-up with the narrower scope @bparrishMines suggested above?

Yes I am, I was thinking at adding this when @bparrishMines work would be ready :-) !

Shubhankt1 · 2022-07-27T12:02:39Z

Hi @dupuchba
I had a good working WebView (webview_flutter: ^2.0.4) and I had implemented file upload as well (based on #3225), but after I updated to API version 31, I got the whole new architecture and the whole file upload issue is broken and without knowing that this happened I have released the new app version to public.

I need a way out ASAP. Could you guide me where do I make the change? I am all confused looking at the new arch.

[UPDATE]: I made the changes to the package based on your changes and still it doesn't work.

dupuchba · 2022-07-28T07:21:08Z

hey @Shubhankt1 I am going on holidays and I don't have the time to get back at this issue. Last April I said I would make a PR with the new plugin architecture for flutter_webview, once it's done.
If you want to make it work it's pretty straightforward, plus you have my PR as an example. Basically I just wrote some platform code for this method https://developer.android.com/reference/android/webkit/WebChromeClient.html#onShowFileChooser(android.webkit.WebView,%20android.webkit.ValueCallback%3Candroid.net.Uri[]%3E,%20android.webkit.WebChromeClient.FileChooserParams)

stuartmorgan · 2022-09-01T20:11:45Z

Status update from triage: Still blocked on flutter/flutter#94051, but we hope to have that resolved soon.

godilite · 2022-10-25T07:47:31Z

Isn't it frustrating that if this a solution, it cannot be merged for everyone to use?

dupuchba · 2022-11-29T08:03:24Z

@godilite to be faire I've not updated my commit to the new platform infrastructure.
And I personally don't think it's frustrating, you can still contribute and make it a reality !

rashidotm · 2022-12-18T07:41:03Z

Hi.

I am happy to see flutter/flutter#94051 merged which was blocking this.

Now, is there a timeframe for when this will be closed? I am holding an update to my app based on your comments.

thanks and best.

dupuchba · 2022-12-20T07:49:44Z

@rashidotm excellent news ! I am probably going to address this in January 23

bparrishMines · 2023-01-11T17:12:57Z

@dupuchba Thanks for your contribution and patience! I had time to work on this, so I went ahead and created #6881, that uses the new infrastructure of the plugin. I'm going to go ahead and close this one in favor of the other.

dupuchba · 2023-01-12T08:04:20Z

@bparrishMines thanks a lot for your time and work.
For what it's worth, it was still on my daily reminder (but I kept pushing it) ^^

dupuchba added 3 commits March 22, 2022 14:37

limitsNavigationsToAppBoundDomains to YES

c6ca542

Merge branch 'main' of github.com:flutter/plugins

4cff35e

Added onShowFileChooser callback on WebView to make upload work on An…

57a1e67

…droidWebView

dupuchba requested a review from bparrishMines as a code owner April 5, 2022 13:57

flutter-dashboard bot added the needs tests label Apr 5, 2022

github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios labels Apr 5, 2022

Update FlutterWebView.m

37d603c

Line was not supposed to be committed

github-actions bot removed the platform-ios label Apr 5, 2022

dupuchba added 2 commits April 5, 2022 16:38

format code

0107550

Merge branch 'android-on-show-file-chooser' of github.com:Roam-Resear…

046e72c

…ch/flutter-plugins into android-on-show-file-chooser

dupuchba changed the title ~~[webview_flutter] Add file chooser on Android~~ [webview_flutter] Add file upload on Android Apr 5, 2022

dupuchba mentioned this pull request Apr 5, 2022

[webview_flutter] not working choose file (input type file) flutter/flutter#27924

Closed

stuartmorgan reviewed Apr 5, 2022

View reviewed changes

danagbemava-nc mentioned this pull request May 4, 2022

java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/core/view/WindowInsetsControllerCompat flutter/flutter#102814

Closed

stuartmorgan mentioned this pull request Jan 3, 2023

[webview_flutter_android] Adds support for receiving Java callback WebChromeClient.onShowFileChooser #6881

Merged

11 tasks

bparrishMines closed this Jan 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter] Add file upload on Android #5172

[webview_flutter] Add file upload on Android #5172

dupuchba commented Apr 5, 2022 •

edited

Loading

flutter-dashboard bot commented Apr 5, 2022

google-cla bot commented Apr 5, 2022

stuartmorgan left a comment

stuartmorgan Apr 5, 2022

bparrishMines Apr 5, 2022

dupuchba Apr 5, 2022

bparrishMines Apr 5, 2022

dupuchba Apr 6, 2022

bparrishMines Apr 7, 2022

Hixie commented Jun 7, 2022

dupuchba commented Jun 8, 2022

Shubhankt1 commented Jul 27, 2022 •

edited

Loading

dupuchba commented Jul 28, 2022

stuartmorgan commented Sep 1, 2022

godilite commented Oct 25, 2022

dupuchba commented Nov 29, 2022

rashidotm commented Dec 18, 2022 •

edited

Loading

dupuchba commented Dec 20, 2022

bparrishMines commented Jan 11, 2023

dupuchba commented Jan 12, 2023

[webview_flutter] Add file upload on Android #5172

[webview_flutter] Add file upload on Android #5172

Conversation

dupuchba commented Apr 5, 2022 • edited Loading

Related issues

Pre-launch Checklist

flutter-dashboard bot commented Apr 5, 2022

google-cla bot commented Apr 5, 2022

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan Apr 5, 2022

Choose a reason for hiding this comment

bparrishMines Apr 5, 2022

Choose a reason for hiding this comment

dupuchba Apr 5, 2022

Choose a reason for hiding this comment

bparrishMines Apr 5, 2022

Choose a reason for hiding this comment

dupuchba Apr 6, 2022

Choose a reason for hiding this comment

bparrishMines Apr 7, 2022

Choose a reason for hiding this comment

Hixie commented Jun 7, 2022

dupuchba commented Jun 8, 2022

Shubhankt1 commented Jul 27, 2022 • edited Loading

dupuchba commented Jul 28, 2022

stuartmorgan commented Sep 1, 2022

godilite commented Oct 25, 2022

dupuchba commented Nov 29, 2022

rashidotm commented Dec 18, 2022 • edited Loading

dupuchba commented Dec 20, 2022

bparrishMines commented Jan 11, 2023

dupuchba commented Jan 12, 2023

dupuchba commented Apr 5, 2022 •

edited

Loading

Shubhankt1 commented Jul 27, 2022 •

edited

Loading

rashidotm commented Dec 18, 2022 •

edited

Loading