Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix for iOS Firebase API changes #569

Merged
merged 2 commits into from
May 13, 2018

Conversation

mravn-google
Copy link
Contributor

Fixes for iOS Firebase API changes: https://firebase.google.com/support/release-notes/ios

TBR

@mravn-google
Copy link
Contributor Author

Committing to fix build, TBR

@mravn-google mravn-google merged commit 4b26c79 into flutter:master May 13, 2018
@mravn-google mravn-google deleted the fb_api_changes branch May 13, 2018 21:19
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizz84
Copy link
Contributor

bizz84 commented Jul 2, 2018

@mravn-google @szakarias Firestore example app doesn't compile on iOS for me due to this change.

Log:

          [document setData:call.arguments[@"data"] merge:YES completion:defaultCompletionBlock];
           ~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/andrea/dev/WORK/MuseVisions/flutter/plugins/packages/cloud_firestore/ios/Classes/CloudFirestorePlugin.m:438:14: error: no visible @interface for 'FIRWriteBatch' declares the selector 'setData:forDocument:merge:'
          [batch setData:call.arguments[@"data"] forDocument:document merge:YES];
           ~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

After flutter packages get my Podfile.lock file appears to be using an old FirebaseFirestore version:

  - Firebase/Firestore (4.13.0):
    - Firebase/Core
    - FirebaseFirestore (= 0.11.0)

Are some changes needed to ensure the latest iOS pod version is used?

Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizz84
Copy link
Contributor

bizz84 commented Jul 2, 2018

This PR goes in tandem with this change on the iOS sdk: https://github.com/firebase/firebase-ios-sdk/pull/1098/files

However, this is available on the iOS sdk 5.0 or above. By default any new Flutter projects using cloud_firestore will incorrectly point to 4.13, so it won't compile for iOS.

I'm not sure how the Firebase plugins choose which underlying sdk versions to use, but it seems like a version should be bumped somewhere for this to work.

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants