Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add stub for In-app purchase plugin #580

Merged
merged 5 commits into from
May 24, 2018

Conversation

szakarias
Copy link
Contributor

No description provided.

@szakarias szakarias force-pushed the createIAPPlugin branch 2 times, most recently from 9bf6eaa to 641434c Compare May 23, 2018 13:07
Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,3 @@
## [0.0.1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using the square brackets in other plugins. Do we need to change the template?

.DS_Store
/build
/captures
GeneratedPluginRegistrant.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add

/gradlew
/gradlew.bat
/gradle/wrapper/gradle-wrapper.jar

here

@@ -0,0 +1,160 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Gradle wrapper shell scripts and jar from repo.

@@ -0,0 +1,63 @@
# Uncomment this line to define a global platform for your project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Podfile from repo. We want to allow Flutter tooling to regenerate it, to ensure the plugin works with the newest version.

@szakarias szakarias merged commit 895ebd7 into flutter:master May 24, 2018
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants