-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
9bf6eaa
to
641434c
Compare
641434c
to
71b1e72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,3 @@ | |||
## [0.0.1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not using the square brackets in other plugins. Do we need to change the template?
.DS_Store | ||
/build | ||
/captures | ||
GeneratedPluginRegistrant.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add
/gradlew
/gradlew.bat
/gradle/wrapper/gradle-wrapper.jar
here
@@ -0,0 +1,160 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Gradle wrapper shell scripts and jar from repo.
@@ -0,0 +1,63 @@ | |||
# Uncomment this line to define a global platform for your project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Podfile
from repo. We want to allow Flutter tooling to regenerate it, to ensure the plugin works with the newest version.
No description provided.