-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Add high resolution iOS photo capture for file #617
Add high resolution iOS photo capture for file #617
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
cc @xster for review |
@Maleandr looks like the clabot wasn't satisfied by your signature? Not sure what's up, can you check to make sure you signed it with the same github account then comment here again? Thanks. |
I signed it via corporate agreement and added my email later. Is this causing issue? I see valid CLA corporate agreement on https://cla.developers.google.com/clas |
CLAs look good, thanks! |
ping @xster |
Seems reasonable. LGTM. Please make sure this change is versioned. Add an entry to packages/camera/CHANGELOG.md and change the version number in packages/camera/pubspec.yaml to 0.2.2. |
I restarted the tests |
Not sure why these tests on Cirrus are failing when it passes on Travis. Can you rebase your 2 commits on head and push again? |
0867ea1
to
230ee0a
Compare
Rebased |
Thanks for your contribution. Merging. |
Added high resolution support for image file saving in iOS.