Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add high resolution iOS photo capture for file #617

Merged
merged 2 commits into from
Jul 21, 2018

Conversation

Maleandr
Copy link
Contributor

Added high resolution support for image file saving in iOS.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Maleandr
Copy link
Contributor Author

I signed it!

@Hixie
Copy link
Contributor

Hixie commented Jun 26, 2018

cc @xster for review

@Hixie
Copy link
Contributor

Hixie commented Jun 26, 2018

@Maleandr looks like the clabot wasn't satisfied by your signature? Not sure what's up, can you check to make sure you signed it with the same github account then comment here again? Thanks.

@Maleandr
Copy link
Contributor Author

I signed it via corporate agreement and added my email later. Is this causing issue? I see valid CLA corporate agreement on https://cla.developers.google.com/clas

@googlebot
Copy link

CLAs look good, thanks!

@Hixie
Copy link
Contributor

Hixie commented Jul 17, 2018

ping @xster

@xster
Copy link
Member

xster commented Jul 18, 2018

Seems reasonable. LGTM.

Please make sure this change is versioned.

Add an entry to packages/camera/CHANGELOG.md and change the version number in packages/camera/pubspec.yaml to 0.2.2.

@xster
Copy link
Member

xster commented Jul 20, 2018

I restarted the tests

@xster
Copy link
Member

xster commented Jul 21, 2018

Not sure why these tests on Cirrus are failing when it passes on Travis. Can you rebase your 2 commits on head and push again?

@Maleandr Maleandr force-pushed the ios_high_resolution_camera_capture branch from 0867ea1 to 230ee0a Compare July 21, 2018 08:05
@Maleandr
Copy link
Contributor Author

Rebased

@xster
Copy link
Member

xster commented Jul 21, 2018

Thanks for your contribution. Merging.

@xster xster merged commit 9b4ae16 into flutter:master Jul 21, 2018
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants