-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview]: Bump webkit from 1.0.0 to 1.5.0 in /packages/webview_flutter/webview_flutter_android/android #6325
Conversation
Bumps webkit from 1.0.0 to 1.5.0. --- updated-dependencies: - dependency-name: androidx.webkit:webkit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@camsim99 @stuartmorgan This change requires bumping the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## 2.10.0 | ||
|
||
* Bumps webkit from 1.0.0 to 1.5.0. | ||
* Raises minimum compileSdkVersion to 32. This requires setting the `compileSdkVersion` in the app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: missing `s on the first `compileSdkVersion.
Do we need the second sentence? IIRC the flutter
tool will give a very clear error message about this.
That was for examples though, which don't affect clients. I would think we would want to do the actual plugin minimum on demand rather than via bulk-update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…view_flutter/webview_flutter_android/android (flutter/plugins#6325)
…view_flutter/webview_flutter_android/android (flutter/plugins#6325)
…view_flutter/webview_flutter_android/android (flutter/plugins#6325)
…er/webview_flutter_android/android (flutter#6325)
…er/webview_flutter_android/android (flutter#6325)
Bumps webkit from 1.0.0 to 1.5.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)