Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Update win32 #6352

Merged
merged 5 commits into from
Sep 3, 2022
Merged

[path_provider] Update win32 #6352

merged 5 commits into from
Sep 3, 2022

Conversation

ThexXTURBOXx
Copy link
Contributor

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

This PR updates the win32 dependency to 3.0.0 to avoid current and future version conflicts.

List which issues are fixed by this PR. You must list at least one issue.

ThexXTURBOXx/flutter_web_auth_2#6

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having a hard time understanding the rationale for bumping the minimum version here.

Can you provide a bit more detail on why this is necessary?

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some comments inline below.

packages/path_provider/path_provider/CHANGELOG.md Outdated Show resolved Hide resolved
packages/path_provider/path_provider_windows/CHANGELOG.md Outdated Show resolved Hide resolved
packages/path_provider/path_provider_windows/pubspec.yaml Outdated Show resolved Hide resolved
@ThexXTURBOXx
Copy link
Contributor Author

@stuartmorgan @cbracken Done

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I made a small style fix since the verb form didn't match our style).

@stuartmorgan
Copy link
Contributor

@cbracken for secondary review.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2022
@auto-submit auto-submit bot merged commit 644d85b into flutter:main Sep 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: path_provider platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants