Added android device id to android device info #639

BWMuller · 2018-06-27T16:40:10Z

No description provided.

googlebot · 2018-06-27T16:40:13Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

BWMuller · 2018-06-27T16:41:27Z

I signed it!

googlebot · 2018-06-27T16:41:29Z

CLAs look good, thanks!

mravn-google

Thanks for the contribution. Please bump the pubspec.yaml version number and add a CHANGELOG.md entry.

mravn-google · 2018-06-28T11:57:52Z

packages/device_info/example/lib/main.dart

@@ -82,6 +82,7 @@ class _MyAppState extends State<MyApp> {
      'tags': build.tags,
      'type': build.type,
      'isPhysicalDevice': build.isPhysicalDevice,
+      'device_id': build.deviceId,


device_id => deviceId

mravn-google · 2018-06-28T11:59:56Z

packages/device_info/android/src/main/java/io/flutter/plugins/deviceinfo/DeviceInfoPlugin.java

@@ -18,6 +21,7 @@

 /** DeviceInfoPlugin */
 public class DeviceInfoPlugin implements MethodCallHandler {
+  private final Activity activity;


I suppose this plugin could work with just a Context, so that it can be used in headless mode too?

mravn-google · 2018-06-28T12:02:18Z

packages/device_info/android/src/main/java/io/flutter/plugins/deviceinfo/DeviceInfoPlugin.java

+  /**
+   * Simple call to get the android hardware device Id that is unique between the device + user and
+   * app signing. This key will change if the app is uninstalled or its data is cleared. Device
+   * factory reset will also result in a value change


[nit] Please end javadoc paragraph with a .

mravn-google · 2018-06-28T12:02:45Z

packages/device_info/lib/device_info.dart

@@ -119,6 +120,9 @@ class AndroidDeviceInfo {
  /// `false` if the application is running in an emulator, `true` otherwise.
  final bool isPhysicalDevice;

+  ///


Dartdoc missing.

mravn-google · 2018-06-28T12:04:52Z

packages/device_info/android/src/main/java/io/flutter/plugins/deviceinfo/DeviceInfoPlugin.java

@@ -79,6 +86,18 @@ public void onMethodCall(MethodCall call, Result result) {
    }
  }

+  /**
+   * Simple call to get the android hardware device Id that is unique between the device + user and


[nits]
Simple call to get => Returns
android => Android
Id => ID

mravn-google · 2018-06-28T12:05:27Z

packages/device_info/android/src/main/java/io/flutter/plugins/deviceinfo/DeviceInfoPlugin.java

@@ -60,6 +66,7 @@ public void onMethodCall(MethodCall call, Result result) {
      build.put("tags", Build.TAGS);
      build.put("type", Build.TYPE);
      build.put("isPhysicalDevice", !isEmulator());
+      build.put("deviceId", getDeviceId());


This ID doesn't really identify the device, as you write below. Maybe rename it to androidId?

kroikie · 2018-09-10T20:30:07Z

Hi @BWMuller would you be able to address the comments on this PR?

BWMuller · 2018-09-11T07:11:22Z

@kroikie Completely forgot about this PR. Have made the changes as indicated

Updated Fork

kroikie · 2018-09-11T15:27:11Z

@BWMuller Thanks for updating the PR, if you would bump the version to 0.3.0 and add an entry in the changelog I'll be happy to merge.

…ter-master # Conflicts: # packages/device_info/lib/device_info.dart

BWMuller · 2018-09-17T11:49:21Z

@kroikie Have bumped the version and updated the branch with master to resolve the conflicts

maxlapides · 2018-10-15T21:17:17Z

this is an awesome and important update! @kroikie do you have an estimate when 0.3.0 will be released to the registry?

* Added android device id to android device info * Bumped device info to version 0.3.0

This reverts commit b9b74ba.

Added android device id to android device info

8d20221

googlebot added the cla: no label Jun 27, 2018

googlebot added cla: yes and removed cla: no labels Jun 27, 2018

Updated formatting of file changes to be according to ci expectations

8638374

BWMuller force-pushed the master branch from 52a9941 to 8638374 Compare June 27, 2018 16:51

mravn-google reviewed Jun 28, 2018

View reviewed changes

mravn-google self-assigned this Jun 28, 2018

kroikie added the needs love label Sep 10, 2018

kroikie unassigned mravn-google Sep 10, 2018

Renamed device Id to androidId

79d6198

BWMuller added 2 commits September 11, 2018 09:42

Merge pull request #1 from flutter/master

f9339e1

Updated Fork

Fixed formatting on comment

5ec310f

BWMuller added 2 commits September 12, 2018 09:01

Bumped device info to version 0.3.0

0a588c7

Merge branch 'master' of https://github.com/flutter/plugins into flut…

8c8a61e

…ter-master # Conflicts: # packages/device_info/lib/device_info.dart

kroikie approved these changes Oct 2, 2018

View reviewed changes

kroikie merged commit e6f85ba into flutter:master Oct 2, 2018

Hixie removed the needs love label Oct 24, 2018

andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019

Added android device id to android device info (flutter#639)

b9b74ba

* Added android device id to android device info * Bumped device info to version 0.3.0

andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019

Revert "Added android device id to android device info (flutter#639)"

b72439d

This reverts commit b9b74ba.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added android device id to android device info #639

Added android device id to android device info #639

BWMuller commented Jun 27, 2018

googlebot commented Jun 27, 2018

BWMuller commented Jun 27, 2018

googlebot commented Jun 27, 2018

mravn-google left a comment

mravn-google Jun 28, 2018

mravn-google Jun 28, 2018

mravn-google Jun 28, 2018

mravn-google Jun 28, 2018

mravn-google Jun 28, 2018

mravn-google Jun 28, 2018

kroikie commented Sep 10, 2018

BWMuller commented Sep 11, 2018

kroikie commented Sep 11, 2018

BWMuller commented Sep 17, 2018

maxlapides commented Oct 15, 2018

Added android device id to android device info #639

Added android device id to android device info #639

Conversation

BWMuller commented Jun 27, 2018

googlebot commented Jun 27, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

BWMuller commented Jun 27, 2018

googlebot commented Jun 27, 2018

mravn-google left a comment

Choose a reason for hiding this comment

mravn-google Jun 28, 2018

Choose a reason for hiding this comment

mravn-google Jun 28, 2018

Choose a reason for hiding this comment

mravn-google Jun 28, 2018

Choose a reason for hiding this comment

mravn-google Jun 28, 2018

Choose a reason for hiding this comment

mravn-google Jun 28, 2018

Choose a reason for hiding this comment

mravn-google Jun 28, 2018

Choose a reason for hiding this comment

kroikie commented Sep 10, 2018

BWMuller commented Sep 11, 2018

kroikie commented Sep 11, 2018

BWMuller commented Sep 17, 2018

maxlapides commented Oct 15, 2018