This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
listener on MobileAd shouldn't be final #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
kroikie
requested review from
mravn-google and
kroikie
and removed request for
mravn-google
kroikie
suggested changes
Jul 25, 2018
| private void callIslAdLoaded(int id, MethodCall call, Result result) { | ||
| MobileAd ad = MobileAd.getAdForId(id); | ||
| if(ad == null) { | ||
| result.error("no_ad_for_id", "isAdLoaded failed, no add exists for id=" + id, null); |
There was a problem hiding this comment.
Nit: Type in message. Should be "no ad exists for id".
Maybe we could also use $id syntax for including the Ad ID in the message.
| @@ -154,6 +154,15 @@ private void callShowAd(int id, MethodCall call, Result result) { | |||
| result.success(Boolean.TRUE); | |||
| } | |||
|
|
|||
| private void callIslAdLoaded(int id, MethodCall call, Result result) { | |||
There was a problem hiding this comment.
I assume this method should be named callIsAdLoaded instead of callIslAdLoaded?
kroikie
suggested changes
Jul 25, 2018
| @@ -32,6 +32,6 @@ android { | |||
| disable 'InvalidPackage' | |||
| } | |||
| dependencies { | |||
| api 'com.google.firebase:firebase-ads:15.+' | |||
| api 'com.google.firebase:firebase-ads:15.0.0' | |||
There was a problem hiding this comment.
Note that the version of this dependency has been bumped to 15.0.1, rebasing on master should resolve this.
|
@mickykebe Really appreciate this PR, would you be able to update this PR so it can be merged in? |
Ad listeners shouldn't necessarily have to be set during Ad initialization.
kroikie
approved these changes
Sep 4, 2018
nichtverstehen
pushed a commit
to nichtverstehen/plugins
that referenced
this pull request
Sep 6, 2018
* listener on MobileAd shouldn't be final * Ad listeners shouldn't necessarily have to be set during Ad initialization. * add isLoaded method to firebase_admob MobileAd checking whether ad has been loaded.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
* listener on MobileAd shouldn't be final * Ad listeners shouldn't necessarily have to be set during Ad initialization. * add isLoaded method to firebase_admob MobileAd checking whether ad has been loaded.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 0d2385c.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* listener on MobileAd shouldn't be final * Ad listeners shouldn't necessarily have to be set during Ad initialization. * add isLoaded method to firebase_admob MobileAd checking whether ad has been loaded.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad listeners shouldn't necessarily have to be set during Ad initialization.