This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Enable no_leading_underscores_for_local_identifiers
#6509
Merged
auto-submit
merged 6 commits into
flutter:main
from
stuartmorgan:analysis-options-local-underscore
Sep 28, 2022
Merged
Enable no_leading_underscores_for_local_identifiers
#6509
auto-submit
merged 6 commits into
flutter:main
from
stuartmorgan:analysis-options-local-underscore
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested review from
cbracken,
cyanglaz,
hellohuanlin,
camsim99,
ditman,
bparrishMines,
gaaclarke and
tarrinneal
as code owners
September 28, 2022 14:25
github-actions
bot
added
p: camera
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: path_provider
p: shared_preferences
p: video_player
p: webview_flutter
Edits files for a webview_flutter plugin
platform-android
platform-ios
platform-linux
platform-macos
platform-web
platform-windows
labels
Sep 28, 2022
hellohuanlin
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up
Sigh, I forgot script/tool/ again. |
stuartmorgan
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Sep 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2022
cbracken
reviewed
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
p: camera
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: path_provider
p: shared_preferences
p: video_player
p: webview_flutter
Edits files for a webview_flutter plugin
platform-android
platform-ios
platform-linux
platform-macos
platform-web
platform-windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
no_leading_underscores_for_local_identifiers
lint to align withflutter/flutter, and fixes all violations.
Part of flutter/flutter#76229
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).