Adding getWifiName to connectivity plugin #685
Conversation
|
@kroikie can you please take a look a this one too? |
|
@kroikie if I may note, please also take a look at the commit d741a53 . Running the flutter_plugin_tools format locally (on my mac) formatted the .h and .m files differently of what's being expected by the CI. ( https://cirrus-ci.com/task/5153579971117056 ) |
There was a problem hiding this comment.
LGTM, @mravn-google would you mind taking a look before this is merged?
| String wifiName = await _methodChannel.invokeMethod('wifiname'); | ||
| // as Android might return <unknown ssid>, uniforming result | ||
| // our iOS implementation will return null | ||
| if (wifiName == "<unknown ssid>") wifiName = null; |
There was a problem hiding this comment.
Nit: Use single quotes here for consistency.
| /// From android 8.0 onwards the GPS must be ON (high accuracy) | ||
| /// in order to be able to obtain the SSID. | ||
| Future<String> getWifiName() async { | ||
| String wifiName = await _methodChannel.invokeMethod('wifiname'); |
There was a problem hiding this comment.
For readability use a camel-cased method name. wifiName instead of wifiname
|
@ffeu about the formatting issues, please make sure that you are using clang-format version 5.0.0. That is the version that the CI is using. |
|
@kroikie noticed that this morning :) |
|
Hi, @kroikie and @mravn-google . Do you guys think we can merge this PR? Please let me know if there's any improvement I can make to it. |
* Adding getWifiName to connectivity plugin
|
Hi @kroikie . In the end this new version didn't get to Dart Pub! Is that something I can do myself? |
|
Hi @ffeu sorry for the delay there, will publish it soon. |
|
Published, @ffeu Thanks again for the PR. |
* Adding getWifiName to connectivity plugin
This reverts commit b5dbd8d.
No description provided.