Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix cloud functions podspec. #691

Merged
merged 4 commits into from
Aug 31, 2018

Conversation

westoque
Copy link
Contributor

This will fix compilation errors when doing a pod install because this package has static framework dependencies.

The error namely:

    [!] The 'Pods-Runner' target has transitive dependencies that include static frameworks: (FirebaseFunctions, FirebaseCore, FirebaseAuth, FirebaseDatabase, and FirebaseFirestore)

@kroikie kroikie self-assigned this Aug 2, 2018
@kroikie kroikie self-requested a review August 29, 2018 20:53
Copy link
Contributor

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @westoque Thanks for this PR, would you be able to bump the version number and add a note in the CHANGELOG?

@westoque
Copy link
Contributor Author

@kroikie sure thing. will bump version and add a note in the CHANGELOG.

This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
@westoque
Copy link
Contributor Author

@kroikie done.

@cdharris
Copy link

@westoque Thanks for noticing these, I've been experiencing this dependency issue for a while and hopefully this solves it

FYI did you perhaps bump the wrong package by mistake? It looks like the updated changelog in firebase_auth not cloud_functions. Would love it if you could bump and release cloud_functions when you get a moment

Cheers

@westoque
Copy link
Contributor Author

@cdharris thanks for the correction! made the changes and pushed.

cc: @kroikie

Copy link
Contributor

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kroikie kroikie merged commit 2dc4852 into flutter:master Aug 31, 2018
@westoque westoque deleted the fix-cloud-functions-podspec branch August 31, 2018 16:27
nichtverstehen pushed a commit to nichtverstehen/plugins that referenced this pull request Sep 6, 2018
* Fix cloud functions podspec.

This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
* Fix cloud functions podspec.

This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Fix cloud functions podspec.

This will fix compilation errors when doing a `pod install` because this package has static framework dependencies.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants