This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[device_info]add android id #700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Aug 22, 2018
| @@ -119,6 +120,20 @@ class AndroidDeviceInfo { | |||
| /// `false` if the application is running in an emulator, `true` otherwise. | |||
| final bool isPhysicalDevice; | |||
|
|
|||
| /// On Android 8.0 (API level 26) and higher versions of the platform, | |||
There was a problem hiding this comment.
We should have a more terse description for this property on its own line for documentation purposes.
There was a problem hiding this comment.
Maybe something along the lines of this:
"A unique 64-bit encoded identifier provided by the platform"
Hixie
reviewed
Oct 30, 2018
| /// constant for the lifetime of the user's device. On devices that have | ||
| /// multiple users, each user appears as a completely separate device, | ||
| /// so the ANDROID_ID value is unique to each user. | ||
| /// A unique 64-bit encoded identifier provided by the platform. |
There was a problem hiding this comment.
We still want the more detailed answer, @bkonyi was just saying that we also want a leading paragraph that is the concise description (because our docs software uses the first paragraph in tables of contents and the like).
Can you put back the text you had before after the new paragraph? :-)
bparrishMines
added
feature
waiting for test harness
and removed
waiting for test harness
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS we have the identifierForVendor to identify the current device. The Secure.ANDROID_ID is the way to do it in Android.
https://developer.android.com/reference/android/provider/Settings.Secure#ANDROID_ID