video_player: Fixed null exception when file has no width or height.

[quentinleguennec]

Since the audio player plugin is not maintained we use the video player to play some mp3 files. It's working fine in iOS but crashing on Android because of a null exception. This fixes it.

[robsonql]

Please accept this PR. I have the same problem.

[owenthereal]

Any update on this?

[luigi-agosti]

It will be nice to have this fix merged

[quentinleguennec]

It's been more than a week now. Can we have an ETA on when this can be merged?

[goderbauer]

Thanks for the contribution! The change looks good to me.

Can you please add an entry to the Changelog and increase the version number in the pubspec.yaml so we can release a version with this bugfix?

Can you also add a test to ensure that this does not regress in the future? Thanks!

[quentinleguennec]

@goderbauer Thank you for the review! I updated the changelog and the pubspec.yaml.

I had a look at the test file and from what I understand the MethodChannel is not tested at all at the moment. This mean I would have to write a complete set of test (for everything). This should be a separate PR I think.

[goderbauer]

LGTM

[goderbauer]

Sadly, I am not in the list of uploaders for this plugin on pub. I've pinged @cbracken, @gspencergoog, and @bkonyi to re-publish it to pub.

[quentinleguennec]

Thanks!

[gspencergoog]

This has been published now. Version 0.7.1 is live.

[dnfield]

@quentinleguennec - I think in this case it might still be nice to have a test where those values are passed in as null, which would fail before this patch but not fail now. We should be able to achieve that by moving the eventListener method outside of the initialize method (effectively making it public instead of private). What do you think?

[quentinleguennec]

@dnfield I think there should be more tests on this plugin since it's very popular. But you are right, we need to start somewhere and that could be a good start :)