Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

bump cloud_firestore android dependencies #829

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

kroikie
Copy link
Contributor

@kroikie kroikie commented Oct 9, 2018

No description provided.

meta: "^1.0.5"
collection: "^1.14.3"
firebase_core: "^0.2.5+1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in dev_dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the plugin explicitly uses firebase_core, it has to be in dependencies

@kroikie kroikie merged commit 3bab1c6 into flutter:master Oct 9, 2018
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
* bump cloud_firestore android dependencies
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* bump cloud_firestore android dependencies
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants