This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add clearMarkers() functionality to GoogleMapController #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
force-pushed
the
clear_markers
branch
from
548f882
to
a1e56a6
Compare
amirh
approved these changes
Oct 11, 2018
| Future<void> clearMarkers() async { | ||
| assert(_markers != null); | ||
| await _markers.forEach((String id, Marker marker) async { | ||
| await _channel.invokeMethod('marker#remove', <String, dynamic>{ |
There was a problem hiding this comment.
nit: would be nice to extract the common part for this and removeMarker to a private method (mainly so we have a single copy of 'marker#remove' in the dart code)
…d by controller#removeMarker and controller#clearMarkers.
amirh
reviewed
Oct 12, 2018
| assert(_markers != null); | ||
| _markers.forEach((String id, Marker marker) async { | ||
| await _removeMarker(id); | ||
| _markers.remove(id); |
There was a problem hiding this comment.
nit: this can be moved into _removeMarker
| notifyListeners(); | ||
| } | ||
|
|
||
| void _removeMarker(String id) { |
There was a problem hiding this comment.
this should return a Future so we can await it
amirh
reviewed
Oct 12, 2018
| /// The returned [Future] completes once listeners have been notified. | ||
| Future<void> clearMarkers() async { | ||
| assert(_markers != null); | ||
| _markers.forEach((String id, Marker marker) async { |
There was a problem hiding this comment.
I think that nothing awaits the closure passed to forEach, so the notifyListeners will happen immediately and the clearMarkers method will complete immediately...
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Add clearMarkers() functionality to GoogleMapController. This method will clear all markers currently present on the map.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to clear all the markers currently on the map. There is currently a method to add, update, and remove a single marker, but not a method to remove all markers.