Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify package name on Integration Testing page #10416

Closed
jarrodcolburn opened this issue Apr 14, 2024 · 1 comment · Fixed by #10433
Closed

Clarify package name on Integration Testing page #10416

jarrodcolburn opened this issue Apr 14, 2024 · 1 comment · Fixed by #10433
Assignees
Labels
e1-hours Effort: < 8 hrs fix.quality Needs improvement in copy quality p2-medium Necessary but not urgent concern. Resolve when possible. test.integration Relates to integration testing

Comments

@jarrodcolburn
Copy link
Contributor

jarrodcolburn commented Apr 14, 2024

In step 4 the package is referred to as introduction *:

import 'package:introduction/main.dart';

In step 3 the the package is referred to as 'counter_app'

In step 1 the package is not given a name in the flutter create command

test the counter app produced by the `flutter create`


Recommend:

updating step 1's flutter create to something like flutter create introduction_to_integration to give explicit package name. Then updating step 3's file tree, and step 4's test file to match.


*there is an introduction package on pub.dev, so this could be confusing

@jarrodcolburn
Copy link
Contributor Author

Sorry this is a pedantic issue. I would normally try to create the PR for it, but I see you're using a preprocessor and so I kinda want to see how you guys do it. Also, my other PR may not even be right now that I think about it.

@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs labels Apr 15, 2024
@atsansone atsansone changed the title Package name is ambiguous/inconsistent Clarify package name on Integration Testing page Apr 19, 2024
@atsansone atsansone added fix.quality Needs improvement in copy quality st.triage.ltw test.integration Relates to integration testing labels Apr 19, 2024
@atsansone atsansone self-assigned this Apr 19, 2024
atsansone added a commit that referenced this issue May 1, 2024
Refactors page to clarify which files are being referenced in particular
sections.

Fixes #10416

---------

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e1-hours Effort: < 8 hrs fix.quality Needs improvement in copy quality p2-medium Necessary but not urgent concern. Resolve when possible. test.integration Relates to integration testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants