Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode to the official documentation #3632

Open
shunjid opened this issue Jun 21, 2019 · 11 comments · May be fixed by #11172
Open

Add dark mode to the official documentation #3632

shunjid opened this issue Jun 21, 2019 · 11 comments · May be fixed by #11172
Assignees
@parlough
Labels
co.proposal Community ask to change an approach or process for docs.flutter.dev e4-months Effort: 1+ months infra.design Relates to the design of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@shunjid
Copy link
Contributor

shunjid commented Jun 21, 2019

It's a feature request. I don't know anyone felt the need of it or, not but I think it would be nicer if @flutter team adds a 'Dark Mode' in the official documentation.

Thank you.
😊

flutter dev_docs(iPad Pro)
@uuttff8
Copy link
Contributor

uuttff8 commented Jun 21, 2019

Agree, as additional it should work with macOS dark theme

@kf6gpe kf6gpe transferred this issue from flutter/flutter Jan 30, 2020
@legalcodes
Copy link
Contributor

legalcodes commented Jan 31, 2020 •
edited
Loading

+1 I'd support this! I frequently work with flutter/website side-by-side with VS Code or IntelliJ (both in dark mode) and it'd be great if flutter/website hard a dark mode toggle for such scenarios.

@legalcodes legalcodes added the co.proposal Community ask to change an approach or process for docs.flutter.dev label Jan 31, 2020
@legalcodes legalcodes mentioned this issue Jan 31, 2020
Closed
@shunjid
Copy link
Contributor Author

shunjid commented Feb 4, 2020

Super excited. Can't wait anymore 😍

@sfshaza2 sfshaza2 added the infra.structure Relates to the tools that create docs.flutter.dev label Feb 6, 2020
@apravint apravint mentioned this issue May 16, 2020
Closed
@tillchen
Copy link

Any updates :D?

@shunjid
Copy link
Contributor Author

shunjid commented Jun 24, 2020

Hi @sfshaza2
Any updates over this?

@sfshaza2
Copy link
Contributor

I'm afraid not, @shunjid. It is just not a priority at the moment. We have no support for website infrastructure right now.

@sfshaza2 sfshaza2 mentioned this issue Oct 3, 2020
Closed
This was referenced Aug 14, 2021
Closed
Closed
@TahaTesser TahaTesser mentioned this issue Sep 7, 2021
Closed
@danagbemava-nc danagbemava-nc mentioned this issue Nov 18, 2021
Closed
@danagbemava-nc danagbemava-nc mentioned this issue Jun 20, 2022
Closed
This was referenced Aug 16, 2022
Closed
Closed
@kissu
Copy link

kissu commented Nov 8, 2022 •
edited
Loading

I guess that dark reader is still the best answer regarding that issue: https://darkreader.org/ (work okay on my side 👍🏻)

@toto6038
Copy link

toto6038 commented Jan 1, 2023

It's 2023. I think this issue deserves priority.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Jan 2, 2023

Well, do have more infrastructure support right now, though I still suspect this will have to wait until after Flutter Forward and probably also after Google I/O.

@parlough
Copy link
Member

parlough commented Jan 2, 2023 •
edited
Loading

We should likely finish #8030 first as well, since the migration has to happen eventually anyway and will make the implementation of dark mode easier as well as avoid extra work later on.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Jan 3, 2023 via email

@parlough parlough mentioned this issue Mar 17, 2023
Closed
@parlough parlough added infra.design Relates to the design of docs.flutter.dev e4-months Effort: 1+ months p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.triage.ltw labels Aug 2, 2023
@danagbemava-nc danagbemava-nc mentioned this issue Oct 9, 2023
Closed
@parlough parlough mentioned this issue May 17, 2024
Closed
@parlough parlough self-assigned this Jun 19, 2024
This was referenced Sep 10, 2024
Merged
Merged
sfshaza2 pushed a commit that referenced this issue Sep 11, 2024
@parlough
Fix styling of text icons (#11124)
b62e0b1 
Contributes to #3632
sfshaza2 pushed a commit that referenced this issue Sep 11, 2024
@parlough
Switch to a new widget placeholder image in the catalog (#11123)
e988263 
This image has a transparent background and works well if the site also
supports dark mode. I also hope to convey the placeholder nature of the
image better.

**!! Let me know what you think.** I'm open to changes or simplifying
back to just the logo. Thanks!

Before:
<img width="200" alt="Before widget placeholder"
src="https://github.com/user-attachments/assets/9438abc6-193b-4a73-b9bb-d4ac4802ced0">

After:
<img width="200" alt="After change widget placeholder"
src="https://github.com/user-attachments/assets/b5d46389-4376-4aff-9c27-c31ba4e74b9b">

**Staged:**
https://flutter-docs-prod--pr11123-misc-new-widget-placeholder-pvgd0q85.web.app/ui/widgets/accessibility

Contributes to #3632
@parlough parlough linked a pull request Sep 24, 2024 that will close this issue
Draft
@parlough parlough added p2-medium Necessary but not urgent concern. Resolve when possible. and removed p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
co.proposal Community ask to change an approach or process for docs.flutter.dev e4-months Effort: 1+ months infra.design Relates to the design of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement site redesign with dark mode flutter/website
8 participants
@kissu @legalcodes @parlough @shunjid @tillchen @uuttff8 @sfshaza2 @toto6038