Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain, link group function on 'An introduction to unit testing' page #5761

Closed
RonyBrosh opened this issue May 9, 2021 · 1 comment · Fixed by #9737
Closed

Explain, link group function on 'An introduction to unit testing' page #5761

RonyBrosh opened this issue May 9, 2021 · 1 comment · Fixed by #9737
Assignees
@atsansone
Labels
a.cookbook Relates to a cookbook recipe or guide e0-minutes Effort: < 60 min from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. test.general Relates to unit, integration, perf testing

Comments

@RonyBrosh
Copy link

RonyBrosh commented May 9, 2021 •
edited by atsansone
Loading

Page URL: https://docs.flutter.dev/cookbook/testing/unit/introduction
Page source: https://github.com/flutter/website/tree/master/src/docs/cookbook/testing/unit/introduction.md

Description of issue:
It's not really clear (at least for me) what is the use case of group keyword.
In the example, Counter is being initiated for each test so how those test are related if they don't share the same Counter instance?
I don't understand the benefit of grouping the tests by reading this document.

Also, What I would like to find on this page (and eventually found by digging the source code) is the setUp and tearDown functions.

As most Android users will have experience with those functions it worth mentioning them.
Hope it makes sense :)
@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. e2-days Effort: < 5 days a.cookbook Relates to a cookbook recipe or guide labels May 14, 2021
@atsansone atsansone added from.page-issue Reported in a reader-filed concern tests test.general Relates to unit, integration, perf testing and removed tests labels May 19, 2023
@atsansone
Copy link
Contributor

Link to the group function. Explain what it means in context.

@atsansone atsansone changed the title 'An introduction to unit testing' page issue Explain, link group function on 'An introduction to unit testing' page May 23, 2023
@atsansone atsansone added ltw-triage e0-minutes Effort: < 60 min and removed e2-days Effort: < 5 days labels May 23, 2023
@atsansone atsansone mentioned this issue May 23, 2023
Closed
@atsansone atsansone self-assigned this Jun 15, 2023
@atsansone atsansone mentioned this issue Oct 31, 2023
Merged
atsansone added a commit that referenced this issue Nov 7, 2023
@atsansone @domesticmouse
Add info on group test function (#9737)
211ab09 
Fleshes out the `group` function for `flutter_test`.

Fixes #5761

---------

Co-authored-by: Brett Morgan <brettmorgan@google.com>
filiph pushed a commit to filiph/website that referenced this issue Nov 9, 2023
@atsansone @domesticmouse @filiph
Add info on group test function (flutter#9737)
8b5ca53 
Fleshes out the `group` function for `flutter_test`.

Fixes flutter#5761

---------

Co-authored-by: Brett Morgan <brettmorgan@google.com>
atsansone added a commit to atsansone/website that referenced this issue Nov 14, 2023
@atsansone @domesticmouse
Add info on group test function (flutter#9737)
06b258c 
Fleshes out the `group` function for `flutter_test`.

Fixes flutter#5761

---------

Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atsansone atsansone

Labels
a.cookbook Relates to a cookbook recipe or guide e0-minutes Effort: < 60 min from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. test.general Relates to unit, integration, perf testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add info on group test function atsansone/website
3 participants
@atsansone @RonyBrosh @sfshaza2