Update wasm page for beta and new docs #10249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 13d17d3): https://flutter-docs-prod--pr10249-wasm-update-1wumv5nf.web.app |
MaryaBelanger
requested review from
sfshaza2,
atsansone,
parlough and
domesticmouse
as code owners
kevmoo
reviewed
Mar 6, 2024
domesticmouse
approved these changes
Mar 7, 2024
|
@kevmoo I set "last updated" to today (March 7), but I switched to the beta channel and followed the steps the page describes in this section and didn't see the "Experimental options" section at the end of the So I'm guessing today is not actually the day; should I change "Last updated" to tomorrow? |
|
@MaryaBelanger – as of RIGHT NOW beta has not landed. Hoping it's soon. |
johnpryan
reviewed
Mar 8, 2024
kevmoo
reviewed
Mar 8, 2024
kevmoo
reviewed
Mar 8, 2024
kevmoo
reviewed
Mar 8, 2024
kevmoo
requested changes
Mar 8, 2024
kevmoo
reviewed
Mar 8, 2024
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
kevmoo
reviewed
Mar 8, 2024
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
kevmoo
approved these changes
Mar 9, 2024
domesticmouse
approved these changes
Mar 10, 2024
src/platform-integration/web/wasm.md
Outdated
| @@ -3,45 +3,53 @@ title: Support for WebAssembly (Wasm) | |||
| description: >- | |||
| Current status of Flutter's experimental support for WebAssembly (Wasm). | |||
| short-title: Wasm | |||
| last-update: November 21, 2023 | |||
| last-update: March 8, 2024 | |||
There was a problem hiding this comment.
Just tagging this line as requires update.
parlough
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks for updating this @MaryaBelanger!
A few suggestions to consider:
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
|
can we land this...like...now? 😄 |
3 tasks
sfshaza2
removed
review.tech
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Mar 18, 2024
Fixes flutter#10159 --------- Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
Fixes flutter#10159 --------- Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10159 --- staged page
Updated the page to:
Things that are NOT in this update (correct me if I'm wrong?):
Dual compile
--wasmoutput goes tobuild/webnotbuild/web_wasmis:wasm-readytag on pub.dev