Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "C++" as a tab language in samplecode/sample #10379

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

eckertl
Copy link
Contributor

@eckertl eckertl commented Apr 6, 2024

Description of what this PR is changing or adding, and why:
Replaces + with -plus as it was also replaced by -plus in the previous fix #6524.

issueFix

Issues fixed by this PR (if any):
fixes #10378

Presubmit checklist

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching and fixing this! Looks great to me :D

@parlough
Copy link
Member

parlough commented Apr 6, 2024

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit d17f202):

https://flutter-docs-prod--pr10379-cpp-fix-i0pk60cz.web.app

@parlough parlough merged commit 9726629 into flutter:main Apr 6, 2024
9 checks passed
atsansone pushed a commit to atsansone/website that referenced this pull request Apr 8, 2024
Replaces `+` with `-plus` as it was also replaced by `-plus` in the
previous fix flutter#6524.

![Video of tabs working after fix](https://github.com/flutter/website/assets/50594304/cec4c8e9-5393-4f51-95e9-00c6c08c713c)

Fixes flutter#10378
sfshaza2 pushed a commit that referenced this pull request Apr 9, 2024
Replaces `+` with `-plus` as it was also replaced by `-plus` in the
previous fix #6524.

![Video of tabs working after fix](https://github.com/flutter/website/assets/50594304/cec4c8e9-5393-4f51-95e9-00c6c08c713c)

Fixes #10378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform-Integration/Platform-Channels: C++ tab isn't working anymore
3 participants