Update index.md #10382
Merged
Update index.md #10382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
centerRight throws of the alignment of the icon with the background of the button on hover.
jaredleishman
requested review from
sfshaza2,
atsansone,
parlough,
domesticmouse and
MaryaBelanger
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
The code you are changing here is excerpted from |
domesticmouse
requested changes
Apr 7, 2024
|
Thanks @domesticmouse, I've updated the source file(s). |
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 56e35af): |
|
/gcbrun |
sfshaza2
approved these changes
Apr 9, 2024
sfshaza2
pushed a commit
that referenced
this pull request
Apr 9, 2024
_Description of what this PR is changing or adding, and why:_ `Alignment.centerRight` throws off the alignment of the icon with the background of the button on hover. When changing the alignment to `Alignment.center`, the gap between the `IconButton` and `_favoriteCount` is a bit bigger. Ultimately I think merging this change is a matter of opinion and take no offense if we keep the existing alignment. NOTE: This was targeting Linux desktop, not mobile. _Issues fixed by this PR (if any):_ #10381 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Brett Morgan <brettmorgan@google.com>
atsansone
pushed a commit
to atsansone/website
that referenced
this pull request
Apr 9, 2024
_Description of what this PR is changing or adding, and why:_ `Alignment.centerRight` throws off the alignment of the icon with the background of the button on hover. When changing the alignment to `Alignment.center`, the gap between the `IconButton` and `_favoriteCount` is a bit bigger. Ultimately I think merging this change is a matter of opinion and take no offense if we keep the existing alignment. NOTE: This was targeting Linux desktop, not mobile. _Issues fixed by this PR (if any):_ flutter#10381 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Brett Morgan <brettmorgan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Alignment.centerRightthrows off the alignment of the icon with the background of the button on hover. When changing the alignment toAlignment.center, the gap between theIconButtonand_favoriteCountis a bit bigger. Ultimately I think merging this change is a matter of opinion and take no offense if we keep the existing alignment.NOTE: This was targeting Linux desktop, not mobile.
Issues fixed by this PR (if any): #10381
Presubmit checklist