-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Web embedding" documentation. #10977
Conversation
/cc @johnpryan @kevmoo @yjbanov FYI! |
Visit the preview URL for this PR (updated for commit bb0e06f): https://flutter-docs-prod--pr10977-web-embedding-docs-o3h28ltv.web.app |
|
||
/// Calls [viewBuilder] for every view added to the app to obtain the widget to | ||
/// render into that view. The current view can be looked up with [View.of]. | ||
class MultiViewApp extends StatefulWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems SUPER complex. It feels like there should be a widget we ship here to do most of this heavy lifting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultiViewApp
is (one of the) widgets you're describing; this is how it's used:
(The viewBuilder
function can (must?) have additional complexity to decide what widgets go into each viewId
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks SO MUCH, @ditman, for this PR! I've done some changes, mostly to make the language less passive. Once you process my feedback, lgtm.
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there!
Apply some more of Shams' suggestions Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Land when ready, @ditman! |
Talked to @kevmoo, we're clicking the button! |
This PR:
(Both of the pages are added under the "Platform integration > Web" section.)
The PR also:
Issues
Fixes: #10773
Presubmit checklist