Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Extract-Archive -> Expand-Archive #11112

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Update: Extract-Archive -> Expand-Archive #11112

merged 1 commit into from
Sep 9, 2024

Conversation

AmosHuKe
Copy link
Contributor

@AmosHuKe AmosHuKe commented Sep 9, 2024 •
edited
Loading

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@AmosHuKe AmosHuKe requested review from sfshaza2, parlough and a team as code owners September 9, 2024 11:09
@AmosHuKe AmosHuKe mentioned this pull request Sep 9, 2024
Closed
1 task
@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 9, 2024

/gcbrun

sfshaza2
sfshaza2 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, @parlough. Can you also give it a gander?

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit f929c16):

https://flutter-docs-prod--pr11112-patch-os-settings-1-9hkvcvwh.web.app

@parlough
Copy link
Member

parlough commented Sep 9, 2024

/gcbrun

parlough
parlough approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

@parlough parlough merged commit 0f24a54 into flutter:main Sep 9, 2024
9 checks passed
@AmosHuKe AmosHuKe deleted the patch-os-settings-1 branch September 10, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 left review comments

@parlough parlough parlough approved these changes

Assignees

@parlough parlough

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmosHuKe @sfshaza2 @flutter-website-bot @parlough