Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external links, most broken by paragraph word-wrapping #1740

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 15, 2018

Contributes to #1413, by fixing all 404 errors. All we are left with now are connection failures (filiph/linkcheck#29).
@chalin chalin requested a review from sfshaza2 November 15, 2018 23:47
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Nov 15, 2018
@@ -377,8 +377,9 @@ and `CustomPainter`, the latter of which implements your algorithm to draw to
the canvas.

To learn how to implement a signature painter in Flutter, see Collin's answer on
[StackOverflow](https://stackoverflow.com/questions/46241071/create-signature-area-
for-mobile-app-in-dart-flutter).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfshaza2, here is an example of a link that is broken by word-wrapping a paragraph containing a link with an embedded URL. It is usually best to create the link definition at the page bottom, or just below the paragraph. In that way, word wrapping won't have this nasty side-effect.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit a96de8d into master Nov 16, 2018
@chalin chalin deleted the chalin-fix-links-1115b branch November 16, 2018 17:21
This was referenced Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken link animations/overview.html
3 participants