Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the GetX package from Options #4981

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Removing the GetX package from Options #4981

merged 1 commit into from
Nov 11, 2020

Conversation

filiph
Copy link
Contributor

@filiph filiph commented Nov 11, 2020

It looks like the package author makes some pretty wild claims* on social media. Removing the links, at least until we can verify that these claims are true.

*) The claims are about the package's official support from Google and/or usage by Google Product Managers — neither of which I'm aware of. I'd also like to verify the claims about performance (currently, they are backed only by a benchmark written by the author).

It looks like the package author makes some pretty wild claims on social media. Removing the links, at least until we can verify that these claims are true.
@filiph filiph requested a review from sfshaza2 November 11, 2020 20:42
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Nov 11, 2020
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, @filiph

@OrlandoEduardo101
Copy link
Contributor

Big day!

@BlackLeg15
Copy link

Make Flutter great again

@pauloantonelli
Copy link

finally! ¬¬.

@geronimoxd
Copy link

take out this shit! #bigday

@MaxweelFreitas
Copy link

Flutter really don't need of a toxic ambient. Let's cut it by root if is true!

@sfshaza2 sfshaza2 merged commit 3f5c42f into master Nov 11, 2020
@sfshaza2 sfshaza2 deleted the filiph-patch-1 branch November 11, 2020 21:17
@fabiojansenbr
Copy link

@filiph do you have any proof of this "wild claims"?

@fabioselau077
Copy link

I hope it's just a mistake and the package is added to the documentation again.
The package is one of the most used in the world by the Flutter community and removing the documentation will be a great loss for new users.

@pauloantonelli
Copy link

I hope it's just a mistake and the package is added to the documentation again.
The package is one of the most used in the world by the Flutter community and removing the documentation will be a great loss for new users.

I don't see it that way! I see that it is a way for new people to start correctly, with tools that follow good opensource practices.

@fabioselau077
Copy link

fabioselau077 commented Nov 11, 2020

I hope it's just a mistake and the package is added to the documentation again.
The package is one of the most used in the world by the Flutter community and removing the documentation will be a great loss for new users.

I don't see it that way! I see that it is a way for new people to start correctly, with tools that follow good opensource practices.

From what I saw the people involved here in the post are from a community that always discussed with the author of the package.
Do you think doing this will contribute to the Flutter and open-source community in general?
Doing everything to harm a package designer who contributes much more to Flutter than you all do just by personal discussions doesn't help anything in the community, it just hurts.
I'm not saying that if he did something bad he shouldn't be punished but contributing to it just because he doesn't like the creator is a bad thing.

@mkiisoft
Copy link
Contributor

@fabiojansenbr yes, we have the proof.

@mkiisoft
Copy link
Contributor

Doing everything to harm a package designer who contributes much more to Flutter than you all do just by personal discussions doesn't help anything in the community, it just hurts.

Please, use a respectful language. This is a healthy community and we don't want toxicity.

@fabiojansenbr
Copy link

@fabiojansenbr yes, we have the proof.

Where? Im Just trying to understand.

@gabrielscr
Copy link

@mkiisoft show us, i wanna see

@fabioselau077
Copy link

Doing everything to harm a package designer who contributes much more to Flutter than you all do just by personal discussions doesn't help anything in the community, it just hurts.

Please, use a respectful language. This is a healthy community and we don't want toxicity.

Doing everything to harm the author of a package just because you don't like it is not toxic, right?

@pauloantonelli
Copy link

I hope it's just a mistake and the package is added to the documentation again.
The package is one of the most used in the world by the Flutter community and removing the documentation will be a great loss for new users.

I don't see it that way! I see that it is a way for new people to start correctly, with tools that follow good opensource practices.

From what I saw the people involved here in the post are from a community that always discussed with the author of the package.
Do you think doing this will contribute to the Flutter and open-source community in general?
Doing everything to harm a package designer who contributes much more to Flutter than you all do just by personal discussions doesn't help anything in the community, it just hurts.
I'm not saying that if he did something bad he shouldn't be punished but contributing to it just because he doesn't like the creator is a bad thing.

I think the issue is not community or package x or y, but the flutter is an environment with good practices from opensource, which always guarantee us software, tools ... reliable and also scalable.

@mkiisoft
Copy link
Contributor

mkiisoft commented Nov 11, 2020

We should call a mod here and close comments as the responses are not going anywhere. Thanks everyone for this effort.

@jehhxuxu
Copy link

jehhxuxu commented Nov 11, 2020

@fabiojansenbr yes, we have the proof.

Where? Im Just trying to understand.

we need to explain? or the package?
https://github.com/jonataslaw/getx/blob/afebab9c7e826a6e994b41017c38f3bb70264178/CHANGELOG.md
image

@rene-kt
Copy link

rene-kt commented Nov 11, 2020

brazilian guys celebrating that a brazilian package was officially removed, smh. Is that the way yall support the community? I mean, theres a plenty of ways to correct this issue, removing the package is a huge step towards back to the community. doesnt make sense: delete a WHOLE package just because of some BS that the creator has said

@OrlandoEduardo101
Copy link
Contributor

brazilian guys celebrating that a brazilian package was officially removed, smh. Is that the way yall support the community? I mean, theres a plenty of ways to correct this issue, removing the package is a huge step towards back to the community. doesnt make sense: delete a WHOLE package just because of some BS that the creator has said

man, did you read? it was only removed from the official flutter documentation.

@rkpontes
Copy link

Removing the Google package will favor a select group that people who are unable to compete honestly and use inefficient arguments. I support Getx as it opens doors for new and experienced developers.

@jonataslaw
Copy link

Well, I'm seeing this now and:
I never said that Google officially supported the package (not least because it doesn't make sense, it is a package, not part of the SDK).
As for the performance issue, there are benchmarks in the repositories, but there is freedom to check.
I hope this is all a misunderstanding, I have always had the greatest respect for the flutter and dart team.
This will cause a revolution in the community, and this is bad.

@mkiisoft
Copy link
Contributor

Everyone here: The package was not removed out of existence, only is not showing as Flutter supported/approved one in the site, that's all. Please, let's close comments for this PR.

@fabioselau077
Copy link

fabioselau077 commented Nov 11, 2020

brazilian guys celebrating that a brazilian package was officially removed, smh. Is that the way yall support the community? I mean, theres a plenty of ways to correct this issue, removing the package is a huge step towards back to the community. doesnt make sense: delete a WHOLE package just because of some BS that the creator has said

I just hovered over their profile and I noticed that they are from a group that has had discussions with the author of the package for years.
I just want to warn you that harming a fantastic plugin just by having a fight with the author is not good.
You are Brazilians, instead of helping a Brazilian who helps the community you are undoing just for the sake of ego.

@edit: I know you guys are going to give my comment a "deslike", but I don't care, I know I'm on the right side of the story and I'm not participating in a closed group that is attacking the package just because I don't like the author.

@rene-kt
Copy link

rene-kt commented Nov 11, 2020

brazilian guys celebrating that a brazilian package was officially removed, smh. Is that the way yall support the community? I mean, theres a plenty of ways to correct this issue, removing the package is a huge step towards back to the community. doesnt make sense: delete a WHOLE package just because of some BS that the creator has said

man, did you read? it was only removed from the official flutter documentation.

yeah, indeed, i get it wrong, sorry, thx anyway

@jehhxuxu
Copy link

Removing the Google package will favor a select group that people who are unable to compete honestly and use inefficient arguments. I support Getx as it opens doors for new and experienced developers.

select group? this is an efficient argument? this is true?
image

@flutter flutter locked as too heated and limited conversation to collaborators Nov 11, 2020
@Hixie
Copy link
Contributor

Hixie commented Nov 11, 2020

Folks, please recall our code of conduct, which is that we must all "Be kind. Be courteous. Be welcoming.".

It's not enough just to be polite. You have to be actively friendly and welcoming. Many of the comments here are unnecessarily antagonistic, aggressive, or generally less than entirely friendly.

@sfshaza2
Copy link
Contributor

Thanks for locking, @Hixie! I was just coming to do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.