Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deprecated ThemeData accent properties breaking-changes doc #5726

Merged
merged 1 commit into from
May 4, 2021
Merged

Added deprecated ThemeData accent properties breaking-changes doc #5726

merged 1 commit into from
May 4, 2021

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented May 3, 2021

I moved the contents of the existing document called theme-data-accent-properties.md to a new documented called fab-theme-data-accent-properties.md because its scope is limited to the FloatingActionButton. The original document's contents have been replaced by material about deprecating the four theme accent properties: accentColor, accentColorBrightness, accentIconTheme, accentTextTheme.

The contents of the theme-data-accent-properties.md document also appear in the pull request that introduced the deprecations: flutter/flutter#81336.

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label May 3, 2021
@HansMuller HansMuller requested a review from sfshaza2 May 3, 2021 20:24
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent and better late than never!!

@sfshaza2 sfshaza2 merged commit 100331c into flutter:master May 4, 2021
@HansMuller HansMuller deleted the add_accent_color_breaking_change_doc branch May 4, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants