Fix Android flavors build.gradle entry example #8177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
requested review from
sfshaza2,
khanhnwin,
domesticmouse,
johnpryan and
atsansone
as code owners
|
Thanks @atsansone! Please take another look :) |
parlough
changed the title
flavorDimensions and use correct property
sfshaza2
reviewed
Jan 31, 2023
|
This looks ready to land! Thanks, @parlough! |
atsansone
reviewed
Feb 1, 2023
|
Yes, please, @parlough. Remember, it's "progress, not perfection!" :D |
|
Please do file an issue for the stuff that needs further tweaking and land it. |
|
I've updated #7979 to track those suggestions and other necessary changes. |
|
@parlough, excellent! @atsansone, can you land this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section could use some further updates, but this at least fixes the existing errors that show up.
Fixes #8096