Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment category title standardization #8809

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Jun 1, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Visit the preview URL for this PR (updated for commit 6145cd3):

https://flutter-docs-prod--pr8809-ia-deployment-titles-wbmyov25.web.app

(expires Fri, 16 Jun 2023 01:24:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one issue and some nits. No need for a second pass.

src/_data/sidenav.yml Outdated Show resolved Hide resolved
src/deployment/flavors.md Show resolved Hide resolved
src/deployment/flavors.md Show resolved Hide resolved
src/deployment/flavors.md Show resolved Hide resolved
@atsansone atsansone added the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jun 1, 2023
parlough and others added 2 commits June 1, 2023 20:16
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
@parlough
Copy link
Member Author

parlough commented Jun 2, 2023

Thanks for taking a look @atsansone! I incorporated the fix (nice catch!), but am going to hold off on the nits as they address existing content that I don't want to touch much in this PR. There is an issue tracking improvements to the flavor page (#7979).

@parlough parlough marked this pull request as ready for review June 2, 2023 01:18
@parlough parlough requested a review from sfshaza2 as a code owner June 2, 2023 01:18
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit c9a851e into main Jun 2, 2023
@sfshaza2 sfshaza2 deleted the ia/deployment-titles branch June 2, 2023 16:06
@sfshaza2 sfshaza2 removed the st.RFM.% Ready to merge or land with minor changes. No further review needed. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants