Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a parameter out of front layer elevation #94

Closed
hendrychjan opened this issue Jun 8, 2021 · 6 comments · Fixed by #109
Closed

Make a parameter out of front layer elevation #94

hendrychjan opened this issue Jun 8, 2021 · 6 comments · Fixed by #109

Comments

@hendrychjan
Copy link

Make font layer elevation a parameter, so that you can easily change the amount of shadow you want to have there.

I've discussed this with Felix (@WieFel) on gitter, he suggested that the elevation here is set to "1", so maybe you could make it a parameter?

@daadu
Copy link
Member

daadu commented Jun 9, 2021

@hendrychjan Thank you for the suggestion.

Can you write the PR for this?

@hendrychjan
Copy link
Author

Sure. How much is it urgent? Can I do it during the weekend?

@WieFel
Copy link
Collaborator

WieFel commented Jun 10, 2021

@hendrychjan sure, whenever you have time! ;)

@shashkiranr
Copy link

is this already implemented?

@WieFel
Copy link
Collaborator

WieFel commented Oct 25, 2021

@shashkiranr not yet. If I find the time, I can have a look...
Of course you can also open a PR for it, if you want ;)

@daadu
Copy link
Member

daadu commented Dec 19, 2021

The feature has landed on pub.dev with v0.7.0.

Thanks @hendrychjan for suggesting it, check yourself in project README!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants