Quick fix to use Sharp Icons #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--Assuming you have set up Pro-- Copy the contents of icon-families.json into the lib/fonts/icons.json This code is backwards compatible so that if you use icons.json it will pull out the relevant fields. icon-families.json doesn't have the styles tag so instead we can iterate over the svgs keys of "classic" and check if it has "sharp" This also means that the key for sharp is now "sharp <thin, light, regular, solid> name" so we have to do some manipulation to remove the empty space to map the Class names correctly and to un-comment out the relevant pubspec.yaml files. I hope this helps someone out to start using Sharp Icons in this.
|
works fine!!! |
|
Thanks @JudahMcNicholl for putting the time into this and providing this pull request. Much appreciated! Also thanks to @matheusbristot for verifying the solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Assuming you have set up Pro--
Copy the contents of icon-families.json into the lib/fonts/icons.json
This code is backwards compatible so that if you use icons.json it will pull out the relevant fields.
icon-families.json doesn't have the styles tag so instead we can iterate over the svgs keys of "classic" and check if it has "sharp"
This also means that the key for sharp is now "sharp <thin, light, regular, solid> name"
so we have to do some manipulation to remove the empty space to map the Class names correctly and to un-comment out the relevant pubspec.yaml files.
I hope this helps someone out to start using Sharp Icons in this.