create a new instance even if dispose is not completed after resetLaz…

[dzziwny]

In app i need to resetLazySingleton in dispose (sync) method in statefull widget. My service dispose method is async and takes long time. Once i am back in widget, Get.I<Foo>() returns me same instance, with on going dispose. For now, the only way to avoid that is to register dispose function as non-Future, like:

GetIt.I.registerLazySingleton<Foo>(
    () => Foo(),
    dispose: (foo) {
      foo.dispose();
    },
  );

but here, await resetLazySingleton<Foo>() will not await my dispose function and nowhere i am able to wait for it. Also from convention, i don't see a point, where i would need to get again (almost) disposed instance - so i think its buggy.

I think:

1. resetLazySingleton<Foo>(); return Get.I<Foo>(); should return a new instance;
2. await resetLazySingleton<Foo>() should await for dispose function with Future type.

[escamoteur]

Hi, interesting find and I agree with your view. I will merge after my vacation.
thanks a lot for contributing

[dzziwny]

Hi, interesting find and I agree with your view. I will merge after my vacation. thanks a lot for contributing

Reminder ;-)

[dzziwny]

@escamoteur can i help somehow?

[dzziwny]

Any update?

[escamoteur]

I know that it's been a long time, but I had to make a longer break due to health issues.

I streamlined your solution a bit. I think:

    dynamic disposeReturn;
    if (instanceFactory.instance != null) {
      if (disposingFunction != null) {
        disposeReturn = disposingFunction.call(instanceFactory.instance! as T);
      } else {
        disposeReturn = instanceFactory.dispose();
      }
    }

    instanceFactory.instance = null;
    instanceFactory.pendingResult = null;
    instanceFactory._readyCompleter = Completer<T>();
    if (disposeReturn is Future) {
      await disposeReturn;
    }
  }

should do the same